Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Add known setup based property types #13041

Merged
merged 2 commits into from Dec 9, 2023
Merged

[tests] Add known setup based property types #13041

merged 2 commits into from Dec 9, 2023

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Dec 8, 2023 •
edited

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited

Codecov Report

Merging #13041 (7ce74ad) into 5.x (f1ff3b2) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                5.x   #13041   +/-   ##
=========================================
  Coverage     58.04%   58.04%           
  Complexity    32965    32965           
=========================================
  Files          2181     2181           
  Lines         98720    98720           
=========================================
+ Hits          57301    57302    +1     
+ Misses        41419    41418    -1

see 1 file with indirect coverage changes

@escopecz escopecz added this to the 5.0-RC2 milestone Dec 8, 2023
@escopecz escopecz added bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code labels Dec 8, 2023
@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Dec 9, 2023 •
edited

Good to go 👍

It seems there is one time-sensitive test, as it always start failing around midnight. I've just rebased and everything passes now.

escopecz
escopecz approved these changes Dec 9, 2023
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types are affecting only tests 👍

@escopecz escopecz merged commit 5b894c7 into mautic:5.x Dec 9, 2023
14 checks passed
@TomasVotruba TomasVotruba deleted the tv-tests-too-step-2 branch December 9, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@mabumusa1 mabumusa1 Awaiting requested review from mabumusa1 mabumusa1 is a code owner

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs refactoring The change does not change behavior but improves the code
Projects
None yet
Milestone
5.0-RC2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TomasVotruba @escopecz