-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Replace header icons from FontAwesome to Remix #13624
[UI] Replace header icons from FontAwesome to Remix #13624
Conversation
6f624dd
to
956649d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the purpose of these changes but my 1 suggestion would be to split this PR into 3 separate PR's. You are combining 3 changes that are not interdependent and some are a bigger change than others.
- moving the notification icon will be a point of contention and should be discussed before making a (separate) PR for it.
- showing the user position/function with the name is a nice improvement but has nothing to do with icons
Love the animation that you made @andersonjeccel to show the user position! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@LordRembo I'm thinking of the previous conversation about finding a balance between the difference/change size and testing efforts… What if try this approach this time to see if people feel happy? If it goes wrong, I cherry pick these commits to another PR and separate them |
Some conflicts here too |
@escopecz Solved! |
@RCheesley Mapped these images on user docs: translations-select-language Notifications is the only/most relevant since it's about its location, is feasible to recapture others again now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love these changes. I think it makes total sense to move the notifications over to the right (I never knew why they were on the left) and the animation on the account is a nice addition.
One thing though, and I know I am being totally pedantic here, but I think it should maybe have a max width for the description after which maybe it should wrap - otherwise this happens: https://app.screencastify.com/v3/watch/CwBm7ATnYWvCc4jZypdl
That can be addressed in another PR though if folks think it needs fixing ;)
@andersonjeccel I am not sure I fully understand the question here? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13624 +/- ##
============================================
- Coverage 61.29% 61.28% -0.01%
Complexity 33998 33998
============================================
Files 2238 2238
Lines 101631 101631
============================================
- Hits 62290 62289 -1
- Misses 39341 39342 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no problem with the code changes 👍
@RCheesley I meant, all these listed images show header with the old location for the notifications icon (even when they’re not the focus) but one image, “notifications” needs to be changed since it’s about where the user can click to find the panel I'd like to know if we could leave the others (unrelated to notifications) as they are since capturing dozens of new images would take a long time to replace |
Only need to update the images which are impacted by the change. |
@andersonjeccel just a reminder that the docs are needed for this PR. |
Had on my to-do list |
Description:
Replaced to the new icon pack.
Added the user's position above their name.
Reordered the notification icon to improve UX.
In the matter of information distribution, we easily realize that items on the right side of the screen are more related to technical management or administration. Either resources such as categories as well as the settings tab, having them all in one side tells users we have a consistency.
So from this, we can think it would also make sense to keep the notification panel icon on the right side of the screen, since often it is responsible for showing information as a new update available.
The left side, on the other hand, commonly presents items that marketers use in everyday work, like contacts, campaigns as well as other necessary resources for the success of a strategy. I believe that keeping only the search icon alone in this side improves consistency, since they will use global search to find these items easily.
Before:
After:
microanimation.mp4
Steps to test this PR: