Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed batch parameter from addLeadToCompany so that it doesn't deta… #2669

Merged
merged 1 commit into from
Oct 11, 2016
Merged

removed batch parameter from addLeadToCompany so that it doesn't deta… #2669

merged 1 commit into from
Oct 11, 2016

Conversation

mqueme
Copy link
Contributor

@mqueme mqueme commented Oct 7, 2016 •
edited

Q A
Bug fix? y
New feature?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #2664 #2666
BC breaks?
Deprecations?

Description:

When submitting a form with a company field, resulted in an error. this PR should fix that

Steps to test this PR:

  1. create a form with a company matched field
  2. submit, company should be created, lead should be created, submission saved

Steps to reproduce the bug:

  1. create a form with a company matched field
  2. submit, you will see a 500 error

@mqueme mqueme added this to the 2.2.1 milestone Oct 7, 2016
@mqueme mqueme added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test Hacktoberfest labels Oct 7, 2016
jordan8037310
jordan8037310 approved these changes Oct 9, 2016
View reviewed changes
Copy link
Contributor

@jordan8037310 jordan8037310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged into my production environment and confirmed no more 500 errors for fields with company mappings.

Thank you!

@escopecz escopecz mentioned this pull request Oct 10, 2016
Closed
@mjdyibrahim
Copy link

I've applied this to 2 mautic installations. Forms are being submitted with data.

P.S. Submission is still quite slow but I guess it doesn't have to do with this.

sambarnes90
sambarnes90 approved these changes Oct 11, 2016
View reviewed changes
Copy link

@sambarnes90 sambarnes90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged this commit and cleared the cache.

Form that was producing a 500 error on submission is now submitting correctly.

No more errors in the log.

Seems to have fixed the issue.

@mqueme mqueme added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test labels Oct 11, 2016
@escopecz
Copy link
Sponsor Member

👍

@alanhartless alanhartless merged commit 961ff23 into mautic:staging Oct 11, 2016
@mjdyibrahim
Copy link

FYI, @mqueme after applying the PR I received a 500 error while adding an "Add to company" campaign action - probably something needs to be updated there as well.

capturecompanyaction

@alanhartless
Copy link
Contributor

@amagdy3 Check your logs for an error.

@mqueme
Copy link
Contributor Author

mqueme commented Oct 11, 2016 •
edited

This was fixed in another PR @amagdy3 @alanhartless #2704

@escopecz escopecz removed ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

@jordan8037310 jordan8037310 jordan8037310 approved these changes

@sambarnes90 sambarnes90 sambarnes90 approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mqueme @mjdyibrahim @escopecz @alanhartless @jordan8037310 @sambarnes90