Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Company select list fixes #2704

Merged
merged 3 commits into from
Oct 11, 2016
Merged

Conversation

alanhartless
Copy link
Contributor

@alanhartless alanhartless commented Oct 10, 2016

Q A
Bug fix? y
New feature? n
Related user documentation PR URL na
Related developer documentation PR URL na
Issues addressed (#s or URLs) #2649 #2683
BC breaks? n
Deprecations? n

Description:

This PR fixes

  1. Editing Company Field from Contact Record #2649 where a company couldn't be removed
  2. Company was not repopulated when editing the campaign set company action

Steps to test this PR:

  1. Apply the PR
  2. Edit a contact and assign a couple companies and save. Delete one save, then delete the second, save. On refresh each time, the company deleted should be gone with finally no companies are left.
  3. Add a "add to company" campaign action. Choose a company and save. Edit the action and the company should be repopulated. Change the company, save, and edit. The new company should be populated.

Steps to reproduce the bug:

  1. Same as above only for contact edit page, the one or more companies may not get deleted.
  2. For campaign, the company will not prefill when editing the action.

@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 10, 2016
@alanhartless alanhartless added this to the 2.2.1 milestone Oct 10, 2016
@mqueme
Copy link
Contributor

mqueme commented Oct 11, 2016

💯 👍

@mqueme mqueme added the pending-test-confirmation PR's that require one test before they can be merged label Oct 11, 2016
@mqueme
Copy link
Contributor

mqueme commented Oct 11, 2016

This also fixes the update send to company company in a campaign

@escopecz
Copy link
Sponsor Member

Both fixes works for me as well. 👍

@escopecz escopecz merged commit a472374 into mautic:staging Oct 11, 2016
@alanhartless alanhartless deleted the bug-company-select branch October 24, 2016 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants