Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide missing plugins from plugin list and fixed updating the is missing flag #2712

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

alanhartless
Copy link
Contributor

Q A
Bug fix? y
New feature? n
Related user documentation PR URL na
Related developer documentation PR URL na
Issues addressed (#s or URLs) #1118
BC breaks? n
Deprecations? n

Description:

When a plugin is marked as missing (uninstalled), it still showed in the plugin list. This PR hides them instead.

Steps to test this PR:

  1. Manually update the is_missing flag for a plugin the plugins table.
  2. View the Plugins - the one marked as missing should not be visible

Steps to reproduce the bug:

  1. Same as above only this time it should be visible regardless of the is missing flag

@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 11, 2016
@alanhartless alanhartless added this to the 2.2.1 milestone Oct 11, 2016
@escopecz
Copy link
Sponsor Member

I tested this with my plugin. It hides/shows the plugin depending if the plugin folder is present after the Install/Update plugins button is hit and cache cleared. 👍

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Oct 11, 2016
Copy link
Contributor

@virlatinus virlatinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test was ok!

@escopecz escopecz merged commit 2878aa3 into mautic:staging Oct 12, 2016
@alanhartless alanhartless deleted the bug-1118 branch October 24, 2016 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants