Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue that caused boolean filters to fail on first save #3033

Merged
merged 2 commits into from
Dec 12, 2016
Merged

Fixed issue that caused boolean filters to fail on first save #3033

merged 2 commits into from
Dec 12, 2016

Conversation

alanhartless
Copy link
Contributor

@alanhartless alanhartless commented Nov 30, 2016 •
edited by dbhurley
Loading

Q A
Bug fix? y
New feature?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

When adding a new boolean filter to a segment, it fails to validate on first save due to the values still being the label. A second save is successful.

Steps to test this PR:

  1. Create a new segment and add a boolean filter. Select a value and save. You should not get a validation message.

Steps to reproduce the bug:

  1. Create a new segment and add a boolean filter. Select a value and save. You'll get a value is not valid message. Save again and it should go through.

@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Nov 30, 2016
@alanhartless alanhartless added this to the 2.4 milestone Nov 30, 2016
@dongilbert dongilbert self-assigned this Dec 9, 2016
@virlatinus virlatinus self-assigned this Dec 9, 2016
@virlatinus
Copy link
Contributor

virlatinus commented Dec 12, 2016 •
edited
Loading

Test works ok! +1

@virlatinus virlatinus added pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test and removed ready-to-test PR's that are ready to test labels Dec 12, 2016
dongilbert
dongilbert approved these changes Dec 12, 2016
View reviewed changes
Copy link
Member

@dongilbert dongilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 works great. Thanks Alan!

@dongilbert dongilbert added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test labels Dec 12, 2016
@alanhartless alanhartless merged commit 95aeb5b into mautic:staging Dec 12, 2016
@alanhartless alanhartless deleted the bug-boolean-filter branch January 13, 2017 03:58
@escopecz escopecz removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Oct 2, 2018
@escopecz escopecz removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongilbert dongilbert dongilbert approved these changes

Assignees

@dongilbert dongilbert

Labels
bug Issues or PR's relating to bugs
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alanhartless @virlatinus @dongilbert @escopecz