change permission compare to use and instead of or #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhartless
added
bug
|
👍 |
|
Hi Chad @drmmr763 ..... Fantastic I can confirm this patch works and when logged into client role I can now access leads and no longer get a 403 with permissions set to Edit Own and View Own for leads. Cheers, |
|
Works. |
drmmr763
added a commit
that referenced
this pull request
Apr 20, 2015
change permission compare to use and instead of or
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permissions for leads had a bug where the if statement was comparing with an
orinstead ofand. This resolves the issue. Reported here:https://www.mautic.org/community/index.php/258-mautic-for-multiple-business/p1#p1095
To test:
Create a role which has permissions only to create, edit own and view own leads. Before patch going to the the lead manager will throw a 403.
After patch the page will properly load and not 403 if you have the correct permissions.