Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact timezone #3215

Closed
wants to merge 9 commits into from
Closed

Contact timezone #3215

wants to merge 9 commits into from

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Jan 10, 2017

Caution, this PR was replaced with #3311

Q A
Bug fix? false
New feature? true
Related user documentation PR URL // @todo
Related developer documentation PR URL null
Issues addressed (#s or URLs) Preparation for #539
BC breaks? N
Deprecations? N

Description:

This PR adds a new Timezone custom field and fills it with a timezone in the PHP's timezone format (continent/city_or_country) based on what Fingerprint2 library sends us as timezone offset in the page hits.

If the Timezone field already exists among the contact custom fields, the migration will just update it.

Steps to test this PR:

  1. Pull this PR
  2. Run app/console doctrine:migrations:migrate
  3. Check that the Timezone custom field was created
  4. Visit a page tracked by Mautic JS tracking in a incognito browser window
  5. Check that the contact who was just tracked is the correct timezone in the contact detail view as well as in the contact edit view.
  6. You can also run phpunit in the app folder to test one unit test that was added.

@escopecz escopecz added this to the 2.6.0 milestone Jan 10, 2017
@escopecz escopecz added feature A new feature for inclusion in minor or major releases needs-documentation PR's that need documentation before they can be merged ready-to-test PR's that are ready to test labels Jan 10, 2017
@escopecz escopecz removed the ready-to-test PR's that are ready to test label Jan 27, 2017
@alanhartless alanhartless self-assigned this Jan 27, 2017
@mqueme mqueme self-assigned this Jan 27, 2017
@escopecz
Copy link
Sponsor Member Author

this PR was replaced with #3311

@escopecz escopecz removed this from the 2.6.0 milestone Jan 27, 2017
@escopecz escopecz removed feature A new feature for inclusion in minor or major releases needs-documentation PR's that need documentation before they can be merged labels Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants