Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the Top Segments Dashboard widget to link to Segment's Contacts #3230

Conversation

isleshocky77
Copy link
Contributor

@isleshocky77 isleshocky77 commented Jan 12, 2017

Q A
Bug fix? N
New feature? N
Related user documentation PR URL None Needed
Related developer documentation PR URL None Needed
Issues addressed (#s or URLs) #3229
BC breaks? N
Deprecations? N

Description:

Currently a default dashboard is Top Lists which uses the Contact Widgets: Top Segments type. This dashboard shows the names of the top segments with a count of Contacts within the Segment.

Currently clicking on the name of the segment is a link to edit the segment while the number of contacts is just plain text. If you go to the Segments page it shows a number of contacts with it being a link to the contacts page filtered by segments.

I would argue that seeing the contacts within a segment is much more useful then being able to edit the Segment.

This is solved bychanging the number of Contacts from plain text to be a link to the Contacts page filtered by segment.

Steps to test this PR:

  1. Go to the homepage and make sure you have the Top Segments widget on the Dashboard
  2. Click on the Name of the Segment
  • You will still be taken to the edit of page of the Segment
  1. Go back to the homepage
  2. Click on the Number of Contacts in the Segment
  • You will now be taken to the list page of Contact being filtered by the Segment

@isleshocky77 isleshocky77 force-pushed the enhancement-top-segments-dashboard-contact-link branch from 128668d to f7349c4 Compare January 30, 2017 19:00
@isleshocky77
Copy link
Contributor Author

Rebased on staging after #3167 merge for CI testing

@isleshocky77 isleshocky77 changed the base branch from master to staging January 30, 2017 19:02
@escopecz escopecz added feature A new feature for inclusion in minor or major releases ready-to-test PR's that are ready to test labels Feb 13, 2017
Changes the displayed number of Contacts in the list of Top Segments to
be a link to the Contacts listing page filtered by that Segment
@isleshocky77 isleshocky77 force-pushed the enhancement-top-segments-dashboard-contact-link branch from f7349c4 to 81968c0 Compare February 17, 2017 20:08
@alanhartless alanhartless added this to the 2.8.0 milestone Apr 3, 2017
@dongilbert dongilbert self-assigned this Apr 6, 2017
@escopecz escopecz assigned escopecz and unassigned virlatinus Apr 12, 2017
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Good Idea! 👍

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Apr 12, 2017
@dongilbert
Copy link
Member

+1 works as described. Thanks!

@dongilbert dongilbert merged commit f52fb6e into mautic:staging Apr 19, 2017
@isleshocky77 isleshocky77 deleted the enhancement-top-segments-dashboard-contact-link branch October 27, 2017 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature for inclusion in minor or major releases pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants