Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass table name on which to drop index #5031

Merged
merged 2 commits into from
Dec 21, 2017
Merged

Pass table name on which to drop index #5031

merged 2 commits into from
Dec 21, 2017

Conversation

phil-davis
Copy link
Contributor

Q A
Bug fix? Y
New feature? N
Related user documentation PR URL n/a
Related developer documentation PR URL n/a
Issues addressed (#s or URLs) #5030
BC breaks? N
Deprecations? N

Description:

Pass the table name to getDropIndexSQL() so that it knows on which table it should drop the old index.

Steps to reproduce the bug:

  1. Have the test DB already set up with fixtures...
  2. Try to reload the fixtures (e.g. after messing around with the data while testing)
php app/console doctrine:fixtures:load --no-interaction --env=test
[2017-09-27 04:16:11]   > purging database
[2017-09-27 04:16:11]   > loading [1] Mautic\UserBundle\DataFixtures\ORM\LoadRoleData
[2017-09-27 04:16:11]   > loading [2] Mautic\UserBundle\DataFixtures\ORM\LoadUserData
[2017-09-27 04:16:13]   > loading [4] Mautic\LeadBundle\DataFixtures\ORM\LoadLeadFieldData

                                                                                                          
  [InvalidArgumentException]                                                                              
  MysqlPlatform::getDropIndexSQL() expects $table parameter to be string or \Doctrine\DBAL\Schema\Table.

Steps to test this PR:

  1. Have the test DB already set up with fixtures...
  2. Try to reload the fixtures (e.g. after messing around with the data while testing)
php app/console doctrine:fixtures:load --no-interaction --env=test
[2017-09-27 04:16:36]   > purging database
[2017-09-27 04:16:36]   > loading [1] Mautic\UserBundle\DataFixtures\ORM\LoadRoleData
[2017-09-27 04:16:36]   > loading [2] Mautic\UserBundle\DataFixtures\ORM\LoadUserData
[2017-09-27 04:16:38]   > loading [4] Mautic\LeadBundle\DataFixtures\ORM\LoadLeadFieldData
[2017-09-27 04:16:40]   > loading [5] Mautic\ReportBundle\DataFixtures\ORM\LoadReportData
[2017-09-27 04:16:40]   > loading [5] Mautic\LeadBundle\DataFixtures\ORM\LoadLeadListData
[2017-09-27 04:16:41]   > loading [5] Mautic\LeadBundle\DataFixtures\ORM\LoadLeadData
[2017-09-27 04:16:42]   > loading [6] Mautic\PageBundle\DataFixtures\ORM\LoadPageCategoryData
[2017-09-27 04:16:42]   > loading [7] Mautic\PageBundle\DataFixtures\ORM\LoadPageData
[2017-09-27 04:16:42]   > loading [8] Mautic\PageBundle\DataFixtures\ORM\LoadPageHitData
[2017-09-27 04:16:43]   > loading [8] Mautic\FormBundle\DataFixtures\ORM\LoadFormData
[2017-09-27 04:16:43]   > loading [9] Mautic\EmailBundle\DataFixtures\ORM\LoadEmailData
[2017-09-27 04:16:43]   > loading [9] Mautic\FormBundle\DataFixtures\ORM\LoadFormResultData
[2017-09-27 04:16:47]   > loading [10] Mautic\AssetBundle\DataFixtures\ORM\LoadAssetData

This was referenced Sep 27, 2017
Closed
Merged
@phil-davis phil-davis force-pushed the fix-fixtures-drop-indexes branch 3 times, most recently from e2a135d to 13d8924 Compare October 7, 2017 10:10
@phil-davis
Copy link
Contributor Author

Rebased

@phil-davis phil-davis force-pushed the fix-fixtures-drop-indexes branch 2 times, most recently from 83177d8 to 184f99c Compare November 23, 2017 10:12
@phil-davis
Copy link
Contributor Author

Rebased on top of #5367 so that CI should pass.

@phil-davis
Copy link
Contributor Author

Rebased again.

@alanhartless alanhartless added this to the 2.12.1 milestone Dec 13, 2017
@alanhartless alanhartless added pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test labels Dec 19, 2017
@javjim javjim self-assigned this Dec 19, 2017
@escopecz escopecz self-assigned this Dec 21, 2017
@escopecz escopecz merged commit 24a6d83 into mautic:staging Dec 21, 2017
@dbhurley dbhurley removed the ready-to-test PR's that are ready to test label Dec 21, 2017
@phil-davis phil-davis deleted the fix-fixtures-drop-indexes branch December 21, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

@escopecz escopecz escopecz approved these changes

Assignees

@escopecz escopecz

@javjim javjim

Labels
pending-test-confirmation PR's that require one test before they can be merged
Projects
None yet
Milestone
2.12.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@phil-davis @alanhartless @escopecz @dbhurley @javjim