Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpcs automated code fixups 2017-11-23 #5367

Closed

Conversation

phil-davis
Copy link
Contributor

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Make code format etc changes as suggested by phpcs

Steps to reproduce the bug:

  1. Run Travis CI
  2. It fails the phpcs checks

Steps to test this PR:

  1. Run Travis CI
  2. It passes phpcs checks

List deprecations along with the new alternative:

List backwards compatibility breaks:

@phil-davis
Copy link
Contributor Author

Followup of #5243 - later code changes in staging have bits and pieces that fail phpcs checks.
Fix these so that phpcs checks pass in CI.

@phil-davis
Copy link
Contributor Author

Pinging those who reviewed on #5243
@alanhartless @Maxell92 @dongilbert @escopecz
You might like to review and quickly merge this, so that CI in staging will pass again for everybody.

@phil-davis
Copy link
Contributor Author

I rebased and discovered that someone else has done these changes also and merged to staging.

@phil-davis phil-davis closed this Nov 27, 2017
@phil-davis phil-davis deleted the phpcs-code-fixup-2017-11-23 branch November 27, 2017 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant