Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow translation of language name into other languages #5111

Closed

Conversation

phil-davis
Copy link
Contributor

Q A
Bug fix?
New feature? Y
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #5110
BC breaks?
Deprecations?

Description:

Steps to test this PR:

  1. Add some translations of language names - French for French is "Francais", for German is "Allemande" etc.
  2. Login and got to the account settings page.
  3. Change you language to French, apply and refresh.
  4. The selected language should be "Francais"
  5. Look in the language dropdown, see the "Allemande" (German) is there, choose it.
  6. Apply and refresh.
  7. The selected language says "Deutsche".
  8. Look in the dropdown for "Türkisch" - it should be there.

List backwards compatibility breaks:

  1. Perhaps this should be a system option - because some installs currently with the system language set to other than English, specially those that use another script (Hindi, East Asian languages...) may or may not want the dropdown list to be localized. e.g. for a non-Chinese person to choose their language from a dropdown list that is all in Chinese script is "difficult". And the same the other way, a KOrean person who does not know latin script struggles to select a language.
    Note: "English - United States" seems to "stick" in the list. So that is some sort of common reference point. If I arrive on a Chinese installation I can first choose "English - United States" then pick the language I really want from the dropdown list in English.

mautic.core.language.en_US="English (USA)"
mautic.core.language.fr="French"
mautic.core.language.de="German"
mautic.core.language.tr="Turkish"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example list, which can be filled out if this seems a "good thing". The translators that are making the fr/message.ini de/messages.ini and so on can then put these keys with strings that are the names of the languages from their point of view "Francais", "Allemand", "Deutsche" etc.

Maybe there is somewhere that already has a matrix lookup table of every known language name from the point of view of every other language?

@phil-davis
Copy link
Contributor Author

Rebased

@phil-davis phil-davis force-pushed the localize-language-names branch 2 times, most recently from 9d41968 to 97a362f Compare November 23, 2017 10:18
@phil-davis
Copy link
Contributor Author

Rebased on top of #5367 so that CI should pass.

@phil-davis
Copy link
Contributor Author

Rebased again

@tedcallier
Copy link

I am all for having language names in all languages. But isn't this PR a solution to something that isn't a problem?

Who hasn't ever set the phone language of a friend to Taiwanese, or Japanese, waiting to see his face when desperately trying to figure our how to set the language back to something he understands?

It would be more helpful if all language names would be shown in their native language. A native French, hooked into an English user-interface doesn't necessarily realise that "Deutsch" is the translation of "Allemand" while he is seeing "German".

@phil-davis
Copy link
Contributor Author

I agree, it is tricky - actually it is probably better (in all software with language selection) to show 2 things for every language in the drop-down list:

  • the name of the language as written by the current language
  • the name of the language as written by its native speakers

So when the current language is English, there would be entries like:

German - Deutsch
Nepalese - नेपाली

I did this PR when I was switching around languages in the UI just testing that stuff seemed to work OK. It seemed easy enough to add in. But certainly not a big issue!

I like to have "as full as possible/reasonable" multi-lingual support in software.

@alanhartless
Copy link
Contributor

I'm fine with this if you want to finish up adding the translation strings for the supported languages.

@alanhartless alanhartless added the pending-feedback PR's and issues that are awaiting feedback from the author label Dec 13, 2017
@dbhurley
Copy link
Member

@phil-davis - update?

@alanhartless
Copy link
Contributor

Closing this as it's very old. If you'd like it re-considered, please submit an updated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-feedback PR's and issues that are awaiting feedback from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants