-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow translation of language name into other languages #5111
Conversation
mautic.core.language.en_US="English (USA)" | ||
mautic.core.language.fr="French" | ||
mautic.core.language.de="German" | ||
mautic.core.language.tr="Turkish" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an example list, which can be filled out if this seems a "good thing". The translators that are making the fr/message.ini
de/messages.ini
and so on can then put these keys with strings that are the names of the languages from their point of view "Francais", "Allemand", "Deutsche" etc.
Maybe there is somewhere that already has a matrix lookup table of every known language name from the point of view of every other language?
51e6a4c
to
7538de9
Compare
7538de9
to
b109a22
Compare
Rebased |
9d41968
to
97a362f
Compare
Rebased on top of #5367 so that CI should pass. |
97a362f
to
b761b24
Compare
Rebased again |
I am all for having language names in all languages. But isn't this PR a solution to something that isn't a problem? Who hasn't ever set the phone language of a friend to Taiwanese, or Japanese, waiting to see his face when desperately trying to figure our how to set the language back to something he understands? It would be more helpful if all language names would be shown in their native language. A native French, hooked into an English user-interface doesn't necessarily realise that "Deutsch" is the translation of "Allemand" while he is seeing "German". |
I agree, it is tricky - actually it is probably better (in all software with language selection) to show 2 things for every language in the drop-down list:
So when the current language is English, there would be entries like:
I did this PR when I was switching around languages in the UI just testing that stuff seemed to work OK. It seemed easy enough to add in. But certainly not a big issue! I like to have "as full as possible/reasonable" multi-lingual support in software. |
I'm fine with this if you want to finish up adding the translation strings for the supported languages. |
@phil-davis - update? |
Closing this as it's very old. If you'd like it re-considered, please submit an updated PR. |
Description:
Steps to test this PR:
List backwards compatibility breaks:
Note: "English - United States" seems to "stick" in the list. So that is some sort of common reference point. If I arrive on a Chinese installation I can first choose "English - United States" then pick the language I really want from the dropdown list in English.