Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken report widget #5196

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Fix broken report widget #5196

merged 2 commits into from
Nov 17, 2017

Conversation

mqueme
Copy link
Contributor

@mqueme mqueme commented Oct 24, 2017

Q A
Bug fix? y
New feature?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #4973
BC breaks?
Deprecations?

Description:

This PR fixes broken report widgets when reports have been deleted. Issue described here. #4973
//: # ( As applicable: )

Steps to reproduce the bug:

  1. Create a report with graphs available.
  2. Create a Report Widget with one of those graphs selected.
  3. Widget should load on the dashboard.
  4. Delete the report.
  5. Reload dashboard and get error.
    5a) You may need to clear cache if the widget data is cached.

Steps to test this PR:

  1. Repeat and the report widget should now show a message saying the report was deleted or no data found.

@mqueme mqueme added bug Issues or PR's relating to bugs Hacktoberfest ready-to-test PR's that are ready to test labels Oct 24, 2017
@mqueme mqueme added this to the 2.11.1 milestone Oct 24, 2017
@alanhartless alanhartless modified the milestones: 2.11.1, 2.12.0 Nov 10, 2017
Maxell92
Maxell92 previously requested changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@Maxell92 Maxell92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is working, but tests are failing

@Maxell92 Maxell92 added the pending-feedback PR's and issues that are awaiting feedback from the author label Nov 16, 2017
@dongilbert
Copy link
Member

Merging latest staging addressed the failing tests. +1

@dongilbert dongilbert merged commit 3821490 into mautic:staging Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongilbert dongilbert dongilbert approved these changes

@Maxell92 Maxell92 Maxell92 left review comments

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs pending-feedback PR's and issues that are awaiting feedback from the author ready-to-test PR's that are ready to test
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mqueme @dongilbert @Maxell92 @alanhartless