Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Fix for #5403 problem with DNC email graphs #5410

Merged
merged 4 commits into from
Dec 20, 2017
Merged

Better Fix for #5403 problem with DNC email graphs #5410

merged 4 commits into from
Dec 20, 2017

Conversation

dbhurley
Copy link
Member

@dbhurley dbhurley commented Dec 2, 2017

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Fixes Issue #5403 500 error on graphs that used the Do Not Contact table. This was because the queries were missing the left join of the dnc table.

Steps to reproduce the bug:

  1. Report --> new
  2. Details: emails sent in Data Source
  3. Graph: Select "Most Emails bounced(Table)" or "Most Emails unsuscribed(Table)"
  4. Save and Close --> 500

Steps to test this PR:

  1. Apply this PR
  2. Repeat above steps

@escopecz escopecz added the bug Issues or PR's relating to bugs label Dec 13, 2017
@alanhartless alanhartless added this to the 2.12.1 milestone Dec 13, 2017
@alanhartless alanhartless added the pending-test-confirmation PR's that require one test before they can be merged label Dec 19, 2017
@javjim javjim self-assigned this Dec 19, 2017
@javjim
Copy link

javjim commented Dec 19, 2017

Working properly, able to reproduce bug, and fix works

@javjim javjim added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Dec 19, 2017
@javjim javjim removed their assignment Dec 19, 2017
@alanhartless alanhartless merged commit 72b06cc into mautic:staging Dec 20, 2017
@dbhurley dbhurley removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs
Projects
None yet
Milestone
2.12.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dbhurley @javjim @alanhartless @escopecz