Use appropriate for loop on preEventDeliveryQueue array instead of for…in

[dongilbert]

Q	A
Bug fix?	Y
New feature?	N
Automated tests included?	N
Related user documentation PR URL	N/A
Related developer documentation PR URL	https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in
Issues addressed (#s or URLs)	Pending
BC breaks?	N
Deprecations?	N

Description:

for...in loops do not work consistently across browsers when using them to iterate over an array. They are not guaranteed to always return in the same order and doing that style of loop on an array returns all properties of the array, not just the numeric indexed items.

This bug was introduced with this commit: a6150e8#diff-33b07c1d837daff498f70f652062659eR215

Steps to reproduce the bug:

1. Create Dynamic Content and embed it in a page where you have loaded the mtc.js
2. Load the page in the Safari or Chrome browsers, and see the console error #<Object> is not a function

Steps to test this PR:

1. Apply PR
2. Retest and see the error no longer appears.

[escopecz]

I wasn't able to replicate the error. My browsers probably doesn't have that problem. It works fine with the update too. 👍

[javjim]

wasnt able to reproduce bug it works properly, maybe someone can test and be able to reproduce bug

[Maxell92]

Cannot replicate an error too. Maybe any specific settings?

[mleffler]

@dongilbert Any comments?

[dongilbert]

No comment

[mleffler]

Looks good, discussed with David, merging.

[mleffler]

#5762