Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use appropriate for loop on preEventDeliveryQueue array instead of for…in #5762

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Use appropriate for loop on preEventDeliveryQueue array instead of for…in #5762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/bundles/CoreBundle/EventListener/BuildJsSubscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,8 @@ function s4() {

if (!MauticJS.firstDeliveryMade) {
MauticJS.firstDeliveryMade = true;
for (var i in MauticJS.postEventDeliveryQueue) {
if (typeof MauticJS.postEventDeliveryQueue[i] == 'function') {
for (var i = 0; i < MauticJS.postEventDeliveryQueue.length; i++) {
if (typeof MauticJS.postEventDeliveryQueue[i] === 'function') {
MauticJS.postEventDeliveryQueue[i](detail);
}
delete MauticJS.postEventDeliveryQueue[i];
Expand Down