Role export access in Leads, Forms, Reports

[kuzmany]

Please be sure you are submitting this against the staging branch.

Q	A
Bug fix?
New feature?	Yes
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Added new permission for export in form results. This PR not require migrations, exports are default enable. This permission give ability disable export permission for Contacts, Forms, Reports.

Steps to test this PR:

1. Create new user with role and enable all permission for Contacts, Forms, Reports with unchecked new Export access: Disable
2. Login as new user and see If exports buttons exists and exports works properly in all sections: Contacts (batch export), Form (results exports) and Reports
3. Open HTML exports of Form results and Reports.
4. Edit in incognito user permission and disable export
5. See If export button are hidden in Form results and Reports and Contacts lists in batch.
6. See If opened HTML export from 3. return access denied after refresh

[kuzmany]

Label: Ready to test

[kuzmany]

Label: WIP

[npracht]

Working from a user perspective ! Bravo !

[npracht]

Label: Pending test confirmation

[npracht]

@kuzmany please solve conflicts ;)

[cykonetic]

👍

[dsp76]

I tested this PR in Gitpod as described. Worked as expected. Only one comment - exporting a single contact is still possible.

[RCheesley]

PHPSTAN issues needing to be addressed here @escopecz - and still need to bump the coverage. Any chance @fedys or @dongilbert might be able to help with that?

[escopecz]

I think the new checkbox should say "Export access: enable" instead of "Export access: disable". I understand it is done because the "enable" option would require a migration or wait for Mautic 5 that allows for some small BC change, but I suggest to do it right instead of do it easy.

[kuzmany]

@escopecz It would be nice suggest it once If it's actual, not 3 years after. It's really getting frustrating to contribute to the community

[escopecz]

@kuzmany I know and I also suffer from the lack of testers. I commented with the same a year ago but that is still a couple years late. I have a plan how to improve this in the future and spend more time here. 🤞

[medsun88]

#7645 #6180 #7246

OMG, Since 2018 we are discussing this feature ( to restrict user from export)
Still not sure when It will be introduced .

I have more than, 25000 Contact in Mautic, and any of my user can easily can export them.
Such a big loophole, and so much discussion.

Guys, this is a Very Import Feature. When it will come ?

@kuzmany @escopecz @RCheesley
Do you have some suggestion to fix this.

[kuzmany]

@medsun88 as you see this is PR and you can use it.

It come to stable version once when it will be approve by team/community/volunteers, finish unit tests, resolve CI checks etc etc.

[RCheesley]

@kuzmany needs some PHPSTAN attention here & the additional test coverage - would be really nice if we can aim to get this into Mautic 5 if it's BC as @escopecz suggests. I am inclined to agree that checking something should be in the affirmative, so if this means it needs to be held to 5.x that is what we should do.

Really appreciate that this is a really old PR and a pain to have to come back to after so long!

[mautibot]

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/how-to-restrict-users-to-export-contact-from-mautic/22845/8

[kuzmany]

@RCheesley we build PR without BC. The suggestions from @escopecz will make BC.
In that case this change need a lot of hours of works, because we already use it in production and the changes make difficult to us. At the moment we are able support just this version of PR. Will see

[medsun88]

Hi @kuzmany @RCheesley

getting error while clearing cache

In RegisterListenersPass.php line 111:

Class "Mautic\LeadBundle\EventListener\SegmentFiltersSubscriber" used for service "mautic.lead.subscriber.
segment.filter" cannot be found.

Check screenshot
https://prnt.sc/CJP17PZobVnt

[xcellenceit]

Reviewers, pls look into this for release. Its been long for such a critical feature.

[escopecz]

@xcellenceit it's not waiting for reviewers but for the rebase and addressing the reported issue

[adiux]

I understand everybody wants this features as soon as possible (me included) as it is critical. However, from a UX standpoint, I strongly agree with @escopecz. We should not change the logic of the checkboxes:

"Export access: enable" instead of "Export access: disable".

It can be a BC Break with v5 now. So we don't need to do a migration. I assume the admin role will get the permission anyway.

[medsun88]

@kuzmany, @escopecz

I understand everybody wants this features as soon as possible (me included) as it is critical. However, from a UX standpoint, I strongly agree with @escopecz. We should not change the logic of the checkboxes:

"Export access: enable" instead of "Export access: disable".

It can be a BC Break with v5 now. So we don't need to do a migration. I assume the admin role will get the permission anyway.

@kuzmany, @escopecz
Any update, When it can be released
it has been pending for a long time.

[kuzmany]

Close favor to M5 version #12884

[kuzmany]

All guys please test updated version for M5 #12884 (unit tests added later)

[medsun88]

I am using Mautic v4.4.12
In which version will it be introduced? It long-awaited feature.