-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Token value after url-encoding. #6078
Conversation
Label: Bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified it is working. @silsha please update to current staging. Thank you.
@galvani I've merged staging into my branch. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as suggested.
@galvani You don’t seem to have write access (anymore?), so your review doesn’t count towards mergeability. |
Description:
From the addressed issue:
Steps to reproduce the bug:
Foo & Bar Inc.
) and one without a company.{contactfield=company|true}
One contact will receive the string
Foo+%26+Bar+Inc.
, the other one will receivetrue
.Steps to test this PR:
Foo & Bar Inc.
) and one without a company.{contactfield=company|true}
One contact will receive the string
Foo+%26+Bar+Inc.
, the other one will receive an empty string.List backwards compatibility breaks:
true
as default value.