Last active as contact field #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzmany
added
ready-to-test
kuzmany
added
WIP
kuzmany
added
ready-to-test
Woeler
added
the
has-conflicts
kuzmany
removed
the
has-conflicts
Woeler
reviewed
Nov 14, 2018
| public function up(Schema $schema) | ||
| { | ||
| $sql = <<<SQL | ||
| INSERT INTO `{$this->prefix}lead_fields` (`is_published`, `label`, `alias`, `type`, `field_group`, `default_value`, `is_required`, `is_fixed`, `is_visible`, `is_short_visible`, `is_listable`, `is_publicly_updatable`, `is_unique_identifer`, `field_order`, `properties`, `object`) |
There was a problem hiding this comment.
Can't this be done with a proper doctrine query builder?
There was a problem hiding this comment.
@Woeler, this style of code writing has already been seen and accepted previously for the 2.14.2 release in this PR https://github.com/mautic/mautic/pull/6520/files
Noa83
approved these changes
Nov 27, 2018
kuzmany
added
pending-test-confirmation
npracht
moved this from Code Review (2 required)
to Ready to Test (confirmation)
in Mautic 2
Mautic 2
automation
moved this from Ready to Test (confirmation)
to Ready to Test (first time)
Jan 15, 2019
alanhartless
approved these changes
Jan 15, 2019
alanhartless
removed
ready-to-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the staging branch.
Description:
This PR added Last active date field as not removed contact field. Same logic like with attribution_date.
The enhancement allow use last_date with campaign contact field condition. Make sense with new campaign capabilities like #6132
Then we can create campaign with condition on last_active date and restart campaign until last_active is not less as some time. For example If contact's last active date is greather like 4 hours then send email/notification (abandoned cart)...
Steps to test this PR:
php app/console doctrine:schema:migration