Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last active as contact field #6279

Merged
merged 6 commits into from Jan 15, 2019

Conversation

Projects
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jul 2, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature? Yes
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR added Last active date field as not removed contact field. Same logic like with attribution_date.
The enhancement allow use last_date with campaign contact field condition. Make sense with new campaign capabilities like #6132

Then we can create campaign with condition on last_active date and restart campaign until last_active is not less as some time. For example If contact's last active date is greather like 4 hours then send email/notification (abandoned cart)...

Steps to test this PR:

  1. Apply PR, run php app/console doctrine:schema:migration
  2. Then go to campaigns and create campaign based on contact field condition with Date last active field
  3. Should works on same way like Attribution date

image

@kuzmany kuzmany added WIP and removed Ready To Test labels Sep 5, 2018

@kuzmany kuzmany added this to the 2.15.0 milestone Sep 5, 2018

kuzmany added some commits Sep 14, 2018

@kuzmany kuzmany added Ready To Test and removed WIP labels Sep 14, 2018

@npracht npracht added this to To do in Testing 2.15.0 Oct 16, 2018

@Woeler Woeler added the Has Conflicts label Nov 6, 2018

@kuzmany kuzmany removed the Has Conflicts label Nov 12, 2018

public function up(Schema $schema)
{
$sql = <<<SQL
INSERT INTO `{$this->prefix}lead_fields` (`is_published`, `label`, `alias`, `type`, `field_group`, `default_value`, `is_required`, `is_fixed`, `is_visible`, `is_short_visible`, `is_listable`, `is_publicly_updatable`, `is_unique_identifer`, `field_order`, `properties`, `object`)

This comment has been minimized.

@Woeler

Woeler Nov 14, 2018

Member

Can't this be done with a proper doctrine query builder?

This comment has been minimized.

@Noa83

Noa83 Nov 27, 2018

Contributor

@Woeler, this style of code writing has already been seen and accepted previously for the 2.14.2 release in this PR https://github.com/mautic/mautic/pull/6520/files

@Noa83

Noa83 approved these changes Nov 27, 2018

Copy link
Contributor

Noa83 left a comment

Ok and tested with success.

@kuzmany kuzmany moved this from To do to Tested once in Testing 2.15.0 Dec 3, 2018

@Woeler Woeler removed this from Tested once in Testing 2.15.0 Dec 5, 2018

@Woeler Woeler modified the milestones: 2.15.0, 2.15.1 Dec 5, 2018

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@npracht npracht moved this from Code Review (2 required) to Ready to Test (confirmation) in Mautic 2 Jan 3, 2019

@alanhartless alanhartless added this to Needs Second Test in 2.15.1 Jan 14, 2019

Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Jan 15, 2019

@alanhartless alanhartless merged commit fa872d9 into mautic:staging Jan 15, 2019

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 15, 2019

@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.