-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New campaign condition: Has active notification #6329
New campaign condition: Has active notification #6329
Conversation
@kuzmany , I was tasked to test this but I am having a hard time understanding the steps to test this PR, please elaborate, thank you. |
@YosuCadilla Just test two contacts. Descriptions is for developers. |
@kuzmany , Developers can code, marketers and other non coders can test. |
@YosuCadilla until 2.14.1 mostly developers tested. But this PR description is just an exception. Please test If contact has or hasn't notification (OneSignal). That's all |
I tested this and it appears to function correctly. https://mautibox.com/6329/s/campaigns/edit/2 |
Please be sure you are submitting this against the staging branch.
Description:
Just added new condition based on active notification from push_ids table.
Prevent too much failed campaign Send notification action.
Steps to test this PR: