Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatId to sendSms result #6351

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Jul 23, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

If You want to use sendToContact API and store identification for internal use.
This PR added statId to response after sendSms

Steps to test this PR:

  1. Create Api and call $smsApi->sendToContact($textMessageId, $contactId);
  2. See response and new statId parameter

@kuzmany kuzmany added ready-to-test PR's that are ready to test enhancement Any improvement to an existing feature or functionality labels Jul 23, 2018
@kuzmany kuzmany added this to the 2.14.1 milestone Jul 23, 2018
@heathdutton heathdutton added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test labels Sep 4, 2018
@heathdutton heathdutton merged commit ee59893 into mautic:staging Sep 4, 2018
@escopecz escopecz removed ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any improvement to an existing feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants