Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case sensitive SugarCRM #6694

Closed
wants to merge 2 commits into from

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Oct 8, 2018

Add exception

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

I've noticed SugarCRM not syn on windows because hook contain case sensitive letters.
Also I've added exception to activity sync. If lead ID doesn't exist, lead activity crash.

Steps to test this PR:

  1. Code review
  2. Then test sync leads and activities to SugarCRM
php app/console mautic:integration:fetchleads -i Sugarcrm  --time-interval="29 days"
php app/console mautic:integration:pushleadactivity -i Sugarcrm  --time-interval="29 days"
  1. If sync works then 👍

List deprecations along with the new alternative:

List backwards compatibility breaks:

Add exception
@kuzmany kuzmany added bug Issues or PR's relating to bugs WIP PR's that are not ready for review and are currently in progress labels Oct 8, 2018
@kuzmany kuzmany added this to the 2.15.0 milestone Oct 8, 2018
@kuzmany kuzmany added ready-to-test PR's that are ready to test and removed WIP PR's that are not ready for review and are currently in progress labels Oct 8, 2018
@npracht npracht added this to To do in Testing 2.15.0 Oct 16, 2018
@Woeler Woeler modified the milestones: 2.15.0, 2.15.1 Dec 5, 2018
@Woeler Woeler removed this from To do in Testing 2.15.0 Dec 5, 2018
@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018
@npracht npracht moved this from Code Review (2 required) to Ready to Test (first time) in Mautic 2 Jan 3, 2019
@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019
@alanhartless
Copy link
Contributor

@kuzmany how did you test the activities? I'm not finding any documentation on how that works. It looks like a custom component in Sugar based on the name. If that's the case, does how it's built in Sugar affect this and by changing it to lowercase, do we break those with it already implemented?

@alanhartless alanhartless added the pending-feedback PR's and issues that are awaiting feedback from the author label Jan 30, 2019
@alanhartless alanhartless moved this from Needs Testing to Discussion in 2.15.1 Jan 30, 2019
@kuzmany
Copy link
Member Author

kuzmany commented Jan 30, 2019

@alanhartless there is no documentation for it. I just took some info from pull requests and some from code research.
#4251 (in this PR I found activity module for SugarCRM)
#4247
I think It was developed some times ago for Webmecanik, then @npracht should know more.

Anyway, we can move this settings to config as parameter and the other devs could change it manually If needed.

@npracht
Copy link
Member

npracht commented Feb 1, 2019

Hello, not for us. I don't know how event works, if a dev can read the code and create a doc that would be awesome :)

@sensalot
Copy link

Can the Vtiger plugin be checked for this issue as well?

@alanhartless alanhartless removed this from Discussion in 2.15.1 Mar 11, 2019
@alanhartless alanhartless removed this from the 2.15.1 milestone Mar 11, 2019
@escopecz escopecz moved this from Ready to Test (first time) to Changes Requested / Review in Mautic 2 Apr 15, 2019
@RCheesley
Copy link
Sponsor Member

@kuzmany did the changes get made for this PR, and/or is it still relevant? Or can we close it down?

@kuzmany kuzmany closed this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs pending-feedback PR's and issues that are awaiting feedback from the author ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants