Fix Sugar/Suite CRM sync for email addresses with an uppercase char

[tsummerer]

Please be sure you are submitting this against the staging branch.

Q	A
Bug fix?	Yes
New feature?	No
Automated tests included?	No
Related user documentation PR URL	n/a
Related developer documentation PR URL	n/a
Issues addressed (#s or URLs)	#7138 #6140
BC breaks?	No
Deprecations?	No

Description:

Currently the code will not properly keep Mautic and Sugar/SuiteCRM in sync when a Lead's email address has any uppercase characters.

Within the SugarcrmIntegration::pushLeads function, a $checkEmailsInSugar array is created. Its keys are forced to be lowercase:

//line 1297
$checkEmailsInSugar[$object][mb_strtolower($lead['email'])] = $lead;

Later, this is compared to a list of CRM records. However, the CRM records are NOT normalized to lowercase. If the system does not find a match, then it marks the IntegrationEntity relationship as deleted

//line 1497
foreach ($sugarLeadRecords as $sugarLeadRecord) {
    if ((isset($sugarLeadRecord) && $sugarLeadRecord)) {
        $email           = $sugarLeadRecord['email1'];
        $key             = mb_strtolower($email);
        $leadOwnerEmails = [];
        foreach ($checkEmailsInSugar as $emailKey => $mauticRecord) {
            if ($email == $emailKey) {     <------

The fix was simple, I just changed $email to $key.

Steps to reproduce the bug:

1. Configure the SugarCRM plugin. Be sure to have at least one field pointing from Mautic to CRM
2. Create a Lead in Mautic - it should have uppercase characters in the email address
3. Run the mautic:integration:synccontacts -i Sugarcrm (or fetchleads (they are synonymous)) command
   This should create the Lead in CRM.
4. Now, edit your Mautic->CRM field in Mautic.
5. Run the command again.

Expected: The field updates in CRM
Actual : The field does not update. Additionally, the integration_entity record has changed from 'lead' to 'lead-deleted'

Steps to test this PR:

1. Repeat steps above after installing PR.

List deprecations along with the new alternative:

1. n/a

List backwards compatibility breaks:

1. n/a

[npracht]

Hi @tsummerer is it duplicate of #6694 ?

[npracht]

@kuzmany ?

[kuzmany]

What about?
Both cases convert to lower and compare?

if ($key == mb_strtolower($emailKey))

[tsummerer]

@npracht - this is completely different from #6694 - that PR is related to case sensitive URL's/module names. This one is focused on Email Address case sensitivity

[tsummerer]

@kuzmany - that would be, I guess, more clear. But it's completely redundant. The $emailKey was already moved to lowercase (see my description and line ~1297). So there's no real reason to do it again.

Given that we strtolower the $email variable four lines above, I think that the original developers used $email when they meant to use $key

[kuzmany]

@tsummere Okay, then it looks good for me.

[escopecz]

Suggested change

*

Please remove this line to make Travis CI happy with code style.