Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for non Outlook condition in email builder #7071

Merged
merged 2 commits into from Jan 30, 2019
Merged

Fix for non Outlook condition in email builder #7071

merged 2 commits into from Jan 30, 2019

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Dec 30, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7048
BC breaks?
Deprecations?

Description:

This PR #6938 fixed non outlook condition in HTML email code generated by MJML mainly. Wrong order made mismatch with translate code back to correct format. This PR should fixed it.

Steps to reproduce the bug:

  1. Create a new email in the Mautic email builder.
  2. Selecting the code mode instead of a template, use the HTML at https://gist.github.com/yrammos/3394aefd8fe388846f5f97c09a895f1b (FWIW, this HTML was generated by MJML).
  3. Click on “apply”.
  4. The progress wheel keeps on spinning indefinitely.
  5. In an effort to circumnavigate the problem and still save the email, click on “close”.
  6. Click on “Save”.
  7. Reopen the builder and look at the preview of the rendered email.
  8. The email does not have the intended appearance because the builder has apparently altered the HTML.

Steps to test this PR:

  1. Load up this PR
  2. Try steps to reproduce and template should works properly.

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Dec 30, 2018
@kuzmany kuzmany added this to the 2.15.1 milestone Dec 30, 2018
@kuzmany kuzmany added this to Ready to Test (first time) in Mautic 2 Dec 30, 2018
@kuzmany kuzmany mentioned this pull request Dec 30, 2018
Closed
@kuzmany kuzmany added WIP PR's that are not ready for review and are currently in progress and removed ready-to-test PR's that are ready to test labels Jan 2, 2019
@npracht npracht moved this from Ready to Test (first time) to Code Review (2 required) in Mautic 2 Jan 3, 2019
@kuzmany kuzmany added ready-to-test PR's that are ready to test and removed WIP PR's that are not ready for review and are currently in progress labels Jan 4, 2019
@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019
@djmonzyk
Copy link

I was getting an error when trying to create the email in Mautibox (unrelated to the PR), so applied this pull to my own environment to test. It fixed the issue for me....well done!

@kuzmany kuzmany added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Jan 29, 2019
Mautic 2 automation moved this from Code Review (2 required) to Ready to Test (first time) Jan 30, 2019
@alanhartless alanhartless merged commit 262fcc3 into mautic:staging Jan 30, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 30, 2019
@alanhartless alanhartless moved this from Needs Testing to Merged in 2.15.1 Jan 30, 2019
@r-martins
Copy link

Worked for me on 2.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged
Projects
No open projects
2.15.1
Merged
Milestone
2.15.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuzmany @djmonzyk @r-martins @alanhartless