Add background-position and background-image to section content and wrapper #7211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add background-image vml support (https://backgrounds.cm)
Enc3phale
changed the title
Enc3phale
changed the title
npracht
added
ready-to-test
npracht
previously approved these changes
Feb 6, 2019
npracht
added
pending-test-confirmation
|
Using in production environment. |
|
@npracht this is a feature rather than a bugfix so it can't go into 2.16.1 - at least that is my understanding of semantic versioning. Let's move it to 3.1? |
|
Yes and no. If we don’t add it in 2.x series we should close it. With the new email builder this is outdated. Let’s add it for people that will stay in 2.x version ?
N.
… On 10 Mar 2020, at 19:25, Ruth Cheesley ***@***.***> wrote:
@npracht this is a feature rather than a bugfix so it can't go into 2.16.1 - at least that is my understanding of semantic versioning. Let's move it to 3.1?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
npracht
added
builder-legacy
Codecov Report
@@ Coverage Diff @@
## features #7211 +/- ##
==============================================
+ Coverage 41.19% 41.20% +0.01%
Complexity 34556 34556
==============================================
Files 2060 2060
Lines 111477 111497 +20
==============================================
+ Hits 45926 45946 +20
Misses 65551 65551
|
|
@RCheesley rebased on actual staging |
npracht
removed
needs-rebase
RCheesley
approved these changes
May 15, 2021
ts-navghane
added a commit
to ts-navghane/mautic
that referenced
this pull request
May 17, 2021
…riteria-ab-tests * 'features' of github.com:mautic/mautic: (269 commits) Add background-position and background-image to section content and wrapper (mautic#7211) Fix API set multiselect empty value (mautic#9506) docs: add hluchas as a contributor (mautic#10039) Sync leaking memory (mautic#9299) docs: add incentfit as a contributor (mautic#10038) docs: add gabepri as a contributor (mautic#10037) form actions that register gotowebinar registrants now save join urls (mautic#9477) docs: add kuzmany as a contributor (mautic#10036) Add readme for Tag Manager repo (mautic#10035) Safe join company table (mautic#9973) docs: add fedys as a contributor (mautic#10034) docs: add anton-vlasenko as a contributor (mautic#10033) docs: add rcheesley as a contributor (mautic#10032) docs: add luguenth as a contributor (mautic#10031) docs: add snoblucha as a contributor (mautic#10030) docs: add stevedrobinson as a contributor (mautic#10029) Add stage name and stage date added to contacts report (mautic#8173) Fix DNC report channel link (mautic#10010) Revert the incorrect changes from previous commits. Fix PR comments. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the staging branch.
Description:
This add background image position and all necessary fields to add image into content in Email builder and Landing builder.
Moreover this add Outlook tag for background-image when the builder is Email builder.
Steps to test this PR: