Safe join company table #9973
Safe join company table #9973
Conversation
As described in mautic#9785 - when generating reports from Leads with Company data the report will throw 500. It is called at least twice - from docker/data/mautic/app/bundles/LeadBundle/EventListener/ReportSubscriber.php:250 - and from docker/data/mautic/app/bundles/LeadBundle/EventListener/ReportSubscriber.php:382 This allows this function to be called more than once safely.
|
Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @snoblucha. |
|
Thanks for making the PR to fix this @snoblucha - if you can sign the contributors agreement that would be awesome! |
RCheesley
added
bug
|
Tested on a 3.3 instance and it works. Thank you, @snoblucha! |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings! |
Codecov Report
@@ Coverage Diff @@
## features #9973 +/- ##
===========================================
Coverage 41.19% 41.19%
- Complexity 34555 34556 +1
===========================================
Files 2060 2060
Lines 111478 111480 +2
===========================================
+ Hits 45921 45927 +6
+ Misses 65557 65553 -4
|
|
@snoblucha could you take care of the code style issue please? We will also need to take care of the test coverage as this PR will result in decreased coverage. Are you able to take a look at the relevant tests and update/improve them? |
kuzmany
added
pending-test-confirmation
|
@all-contributors please add @kuzmany for userTesting |
|
I've put up a pull request to add @kuzmany! 🎉 |
|
@all-contributors please add @kuzmany for review |
|
I've updated the pull request to add @kuzmany! 🎉 |
There was a problem hiding this comment.
Thanks for the PR @snoblucha - was able to reproduce the issue and the PR has addressed it! 🎉
LGTM 🚀
|
@all-contributors please add @stevedrobinson for userTesting |
|
I've put up a pull request to add @stevedrobinson! 🎉 |
|
@all-contributors please add @snoblucha for code and bug |
|
I've put up a pull request to add @snoblucha! 🎉 |
…riteria-ab-tests * 'features' of github.com:mautic/mautic: (269 commits) Add background-position and background-image to section content and wrapper (mautic#7211) Fix API set multiselect empty value (mautic#9506) docs: add hluchas as a contributor (mautic#10039) Sync leaking memory (mautic#9299) docs: add incentfit as a contributor (mautic#10038) docs: add gabepri as a contributor (mautic#10037) form actions that register gotowebinar registrants now save join urls (mautic#9477) docs: add kuzmany as a contributor (mautic#10036) Add readme for Tag Manager repo (mautic#10035) Safe join company table (mautic#9973) docs: add fedys as a contributor (mautic#10034) docs: add anton-vlasenko as a contributor (mautic#10033) docs: add rcheesley as a contributor (mautic#10032) docs: add luguenth as a contributor (mautic#10031) docs: add snoblucha as a contributor (mautic#10030) docs: add stevedrobinson as a contributor (mautic#10029) Add stage name and stage date added to contacts report (mautic#8173) Fix DNC report channel link (mautic#10010) Revert the incorrect changes from previous commits. Fix PR comments. ...
Description:
As described in #9785 - when generating reports from Leads with Company data the report will throw 500.
It is called at least twice
This allows this function to be called more than once safely.
Steps to test this PR: