New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support translation for segment anniversary filters #7228
Support translation for segment anniversary filters #7228
Conversation
Hi there! We now want to integrate your contribution in the Mautic 3 roadmap as 3.1.0 candidate. How to do?
Please report results by commenting on your PR to make us administration easier. You can more information on how to do all of that on this blog post "Getting you PR ready for Mautic 3". |
Codecov Report
@@ Coverage Diff @@
## 4.x #7228 +/- ##
============================================
+ Coverage 44.60% 45.51% +0.91%
- Complexity 34877 38890 +4013
============================================
Files 2089 2082 -7
Lines 116938 126510 +9572
============================================
+ Hits 52157 57584 +5427
- Misses 64781 68926 +4145
|
6f2c41b
to
d27414a
Compare
Bumping to 3.2 due to lack of testing |
Documentation already mentions that it is translatable. I'll remove the label saying it misses documentation.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PR following the instructions and all of the steps worked great in the English and French versions.
Thanks for the PR @kuzmany just needs a test/code review to be merged!
Bumping from the release due to lack of testing/code review. |
Close favor to #10541 |
Please be sure you are submitting this against the staging branch.
Description:
This PR is related to already merged to #6993
We've added support for anniversary, but now need support for translated anniversary filter.
If you're using english language:
If you're using french language, you are able to use these format:
This PR bring new DateRelativeParser (tests include) https://github.com/mautic/mautic/pull/7228/files#diff-bbfe9f8aca314124ce61104c7207459b
That classes also use in another PR #6710
Class parse string based on own dictionary or related date start with +/-.
Steps to test this PR:
Devs can also check logs on dev enviroment
I see for first segment
For second segment
6. Then remove segments and switch Mautic to french language
7. Create same two segments as above + create additional two segments with french language in filter: