New Slot | Signature

[moskoweb]

Q	A
Bug fix?	N
New feature?	Y
Automated tests included?	N
Related user documentation PR URL	N
Related developer documentation PR URL	N
Issues addressed (#s or URLs)	N
BC breaks?
Deprecations?

Description:

Creation of a new Slot for the creator of email, this time a practical way of putting a professional signature in the emails.

You can customize with name, bio, image, email, phone and website.

In addition to the colors that can be customized as desired.

Steps to reproduce:

1. Create new email
2. Add slot Signature

[Strubbel94]

Minor Issue:
After saving the Email or applying changes the Email field in the Customize Slot appears empty.

Despite this issue, the Feature is working fine.

[npracht]

Hi there!
It has been decided to not create any extra Mautic 2 minor versions (which means no more features in M2) knowing that Mautic 3 is coming very soon.

We now want to integrate your contribution in the Mautic 3 roadmap as 3.1.0 candidate.

How to do?

1. Check if your feature or enhancement is still missing and relevant in Mautic 3
2. If Yes: rebase your PR against the 3.x branch
3. If No: please consider closing your PR if you are absolutely sure that the feature has made it into Mautic 3 already

Please report results by commenting on your PR to make us administration easier.

---

You can more information on how to do all of that on this blog post "Getting you PR ready for Mautic 3".

[RCheesley]

@cla-bot check

Hi @moskoweb thanks for this PR! It looks like we have a config file conflict that needs to be addressed if this is still good to go for Mautic 3.x and you need to sign the contributors agreement - could you take a look?

I'll tag it for the 3.2 release provisionally, that would mean getting it tested and ready to go no later than Sunday, 15th November.

[cla-bot]

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact @RCheesley. CLA has not been signed by @moskoweb.

[cla-bot]

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

[cla-bot]

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact @RCheesley. CLA has not been signed by @moskoweb.

[TravisBuddy]

Travis tests have failed

Hey @moskoweb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0b8a8db0-fc34-11ea-a343-ef792cdaf85e

[RCheesley]

@cla-bot check

[cla-bot]

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

[codecov]

Codecov Report

Merging #7421 (442d128) into features (b84c8f4) will decrease coverage by 1.61%.
The diff coverage is 0.00%.

❗ Current head 442d128 differs from pull request most recent head ff6a50b. Consider uploading reports for the commit ff6a50b to get more accurate results

@@              Coverage Diff               @@
##             features    #7421      +/-   ##
==============================================
- Coverage       41.25%   39.63%   -1.62%     
+ Complexity      34563    33980     -583     
==============================================
  Files            2060     1990      -70     
  Lines          111535   105742    -5793     
==============================================
- Hits            46014    41913    -4101     
+ Misses          65521    63829    -1692     

Impacted Files	Coverage Δ	Complexity Δ
...bundles/CoreBundle/Form/Type/SlotSignatureType.php	0.00% <0.00%> (ø)	2.00 <2.00> (?)
...es/EmailBundle/EventListener/BuilderSubscriber.php	42.77% <0.00%> (-50.29%)	26.00 <0.00> (ø)
plugins/MauticCrmBundle/Api/CrmApi.php	0.00% <0.00%> (-100.00%)	1.00% <0.00%> (ø%)
app/bundles/CoreBundle/Form/Type/SlotType.php	0.00% <0.00%> (-100.00%)	2.00% <0.00%> (ø%)
plugins/MauticFocusBundle/Helper/TokenHelper.php	0.00% <0.00%> (-100.00%)	7.00% <0.00%> (ø%)
app/bundles/CoreBundle/Form/Type/SlotTextType.php	0.00% <0.00%> (-100.00%)	1.00% <0.00%> (ø%)
plugins/MauticCitrixBundle/MauticCitrixBundle.php	0.00% <0.00%> (-100.00%)	1.00% <0.00%> (ø%)
...pp/bundles/CoreBundle/Form/Type/SlotButtonType.php	0.00% <0.00%> (-100.00%)	2.00% <0.00%> (ø%)
...lugins/MauticSocialBundle/Form/Type/ConfigType.php	0.00% <0.00%> (-100.00%)	3.00% <0.00%> (ø%)
.../bundles/CoreBundle/Form/Type/SlotCodeModeType.php	0.00% <0.00%> (-100.00%)	2.00% <0.00%> (ø%)
... and 492 more

[RCheesley]

@moskoweb I am not sure if this PR is still relevant given the new builder, but if you do still want it to be considered please can you take a look at the codestyle issues and the failing tests?

If you prefer not to take this forward, let's close the PR.

[RCheesley]

@moskoweb given this has had no activity in many months I am going to close the PR. If you want to pick it up again in the future just comment to let us know.