Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autofilling when using multiple autofill fields #7487

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
4 participants
@hluchas
Copy link
Contributor

commented Apr 30, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included? Y
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description: When using multiple checkbox groups or selects, only first one is autofilled.

Steps to reproduce the bug:

  1. Create multiple Boolean or Select custom fields
  2. Create form with checkbox groups mapping to those custom fields, using "Use assigned contact/company field's list choices. = Yes" in the Properties Tab
  3. Add form to a landing page, then submit form with at least one of those checkboxes checked
  4. Refresh landing page that the form is on

Steps to test this PR:

  1. Load up this PR
  2. Use reproduction steps

@npracht npracht added this to the 2.15.2 milestone May 2, 2019

@npracht npracht added this to Ready to Test (first time) in Mautic 2 May 2, 2019

@escopecz

This comment has been minimized.

Copy link
Member

commented May 7, 2019

@kuzmany @hluchas is this duplicate of #7347?

@kuzmany

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

@escopecz yes it is, our #7347 fix radio + checkbox + some boolean unexpected autofill behaviour with it

@hluchas

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Funny, but OK. I would like to merge my PR naturally and because I've better division for alias _'.$alias.'_'., but @kuzmany has more fixed in it.

I don't know.

@escopecz escopecz moved this from Ready to Test (first time) to Ready to Test (confirmation) in Mautic 2 May 13, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

We're going to close 2.15.2 release, then I decide to close this PR favor to #7347
Better regex division could be submitted in another PR.

@kuzmany kuzmany closed this May 19, 2019

Mautic 2 automation moved this from Ready to Test (confirmation) to Merged May 19, 2019

@escopecz escopecz removed this from Merged in Mautic 2 May 20, 2019

@escopecz escopecz removed this from the 2.15.2 milestone May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.