Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing deprecations from CampaignBundle #8374

Merged
merged 11 commits into from Feb 3, 2020
Merged

Removing deprecations from CampaignBundle #8374

merged 11 commits into from Feb 3, 2020

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Jan 30, 2020 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? N
New feature? N
Automated tests included? /
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? Y
Deprecations? N

Description:

I noticed that some deprecated methods are still present in the CampaignBundle and most of them were easy to remove. This PR removes them and replaces their usages.

Steps to test this PR:

  1. Load up this PR
  2. Ensure campaign event processing works as before.

List backwards compatibility breaks:

  1. See https://github.com/mautic/mautic/pull/8374/files#diff-0901ceb76939b17cd920bc69aa52d21f

@escopecz
Removing deprecated methods from CampaignModel
3369e53 
The deprecated methods were used in several places so I replaced those usages with suggested replacements.
@escopecz
Removing deprecated LegacyEventModel
6fa15a9
@escopecz
Test fix
4a01bd9
@escopecz escopecz added code-review-needed PR's that require a code review before merging Mautic 3 ready-to-test PR's that are ready to test labels Jan 30, 2020
@escopecz escopecz added this to Needs code review and/or test in Mautic 3 Jan 30, 2020
@escopecz escopecz added this to the 3.0.0 milestone Jan 30, 2020
@escopecz escopecz moved this from Needs code review and/or test to In progress in Mautic 3 Jan 30, 2020
@escopecz escopecz self-assigned this Jan 30, 2020
@escopecz escopecz moved this from In progress to Needs code review and/or test in Mautic 3 Jan 30, 2020
@dongilbert dongilbert self-requested a review January 30, 2020 15:37
dongilbert
dongilbert approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@dongilbert dongilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review +1

@escopecz escopecz removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Feb 3, 2020
@escopecz escopecz merged commit c15a50a into mautic:3.x Feb 3, 2020
@escopecz escopecz deleted the m3.removing-deprecations branch February 3, 2020 09:32
@escopecz escopecz moved this from Needs code review and/or test to Done in Mautic 3 Feb 3, 2020
@escopecz escopecz mentioned this pull request Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongilbert dongilbert dongilbert approved these changes

Assignees

@escopecz escopecz

Labels
None yet
Projects
No open projects
Mautic 3
  
Done
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@escopecz @dongilbert