Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing campaign detail page #8390

Merged
merged 4 commits into from Feb 4, 2020
Merged

Fixing campaign detail page #8390

merged 4 commits into from Feb 4, 2020

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Feb 4, 2020

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? Y
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? N
Deprecations? N

Description:

#8374 broke the campaign detail page. This PR adds a functional test that ensures the details page loads properly and fixes the issue.

Steps to reproduce the bug:

  1. Go to a campaign detail page.
  2. Notice it's broken.

Steps to test this PR:

  1. Load up this PR
  2. The campaign detail page is loading as before.

@escopecz escopecz changed the title Creating functional test that shows the error Fixing contacts detail page Feb 4, 2020
@escopecz escopecz self-assigned this Feb 4, 2020
@escopecz escopecz added bug Issues or PR's relating to bugs code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test regression A bug that broke something in the last release T1 Low difficulty to fix (issue) or test (PR) labels Feb 4, 2020
@escopecz escopecz added this to the 3.0.0 milestone Feb 4, 2020
@escopecz escopecz added this to In progress in Mautic 3 Feb 4, 2020
@escopecz escopecz moved this from In progress to Needs code review and/or test in Mautic 3 Feb 4, 2020
@escopecz escopecz changed the title Fixing contacts detail page Fixing campaign detail page Feb 4, 2020
hluchas
hluchas approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@hluchas hluchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@escopecz escopecz merged commit f301ef2 into mautic:3.x Feb 4, 2020
@escopecz escopecz removed code-review-needed PR's that require a code review before merging T1 Low difficulty to fix (issue) or test (PR) ready-to-test PR's that are ready to test labels Feb 4, 2020
@escopecz escopecz moved this from Needs code review and/or test to Done in Mautic 3 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hluchas hluchas hluchas approved these changes

Assignees

@escopecz escopecz

Labels
bug Issues or PR's relating to bugs regression A bug that broke something in the last release
Projects
No open projects
Mautic 3
  
Done
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@escopecz @hluchas