Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mautic:migrations:generate command replaced with doctrine:migrations:generate #8429

Merged
merged 5 commits into from Feb 12, 2020
Merged

mautic:migrations:generate command replaced with doctrine:migrations:generate #8429

merged 5 commits into from Feb 12, 2020

Conversation

escopecz
Copy link
Sponsor Member

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? /
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? Y
Deprecations? N

Description:

Command bin/console mautic:migrations:migrate does not work anymore with upgraded Doctrine. @dongilbert helped me to find another way how to generate custom migrations. We can use the original bin/console doctrine:migrations:migrate command and provide a custom template instead.

Steps to reproduce the bug:

  1. Run bin/console mautic:migrations:migrate
  2. See the error
In ConnectionNotSpecified.php line 13:
  You have to specify a --db-configuration file or pass a Database Connection as a dependency to the Migrations.

Steps to test this PR:

  1. Run bin/console doctrine:migrations:migrate
  2. It will generate the migration class for you.

List backwards compatibility breaks:

  1. See the Upgrade doc.

@escopecz
mautic:migrations:generate command replaced with doctrine:migrations:…
9ff854a 
…migrate

The Mautic command stopped working with the Doctrine update. But it's also easier to configure custom template with the original Doctrine command, so we did that.
@escopecz
Removed command added to the Upgrade doc
95b044d
@escopecz escopecz added code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test regression A bug that broke something in the last release labels Feb 12, 2020
@escopecz escopecz self-assigned this Feb 12, 2020
@escopecz escopecz added this to the 3.0.0 milestone Feb 12, 2020
@escopecz escopecz added this to Needs code review and/or test in Mautic 3 Feb 12, 2020
dongilbert
dongilbert reviewed Feb 12, 2020
View reviewed changes
UPGRADE-3.0.md Outdated Show resolved Hide resolved
@escopecz escopecz merged commit dc867ca into mautic:3.x Feb 12, 2020
@escopecz escopecz deleted the generate-migration-fix branch February 12, 2020 20:18
@escopecz escopecz removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Feb 12, 2020
@escopecz escopecz moved this from Needs code review and/or test to Done in Mautic 3 Feb 12, 2020
@escopecz escopecz changed the title mautic:migrations:generate command replaced with doctrine:migrations:migrate mautic:migrations:generate command replaced with doctrine:migrations:generate Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongilbert dongilbert dongilbert approved these changes

Assignees

@escopecz escopecz

Labels
regression A bug that broke something in the last release
Projects
No open projects
Mautic 3
  
Done
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@escopecz @dongilbert