mautic:migrations:generate command replaced with doctrine:migrations:generate

.travis.yml

@@ -44,4 +44,4 @@ jobs:
       script: composer rector -- --dry-run --no-progress-bar
     -
       name: CS Fixer
-      script: bin/php-cs-fixer fix --config=.php_cs -v --dry-run --using-cache=no --show-progress=dots --diff $(git diff --name-only --diff-filter=ACMRTUXB "${TRAVIS_COMMIT_RANGE}")
+      script: bin/php-cs-fixer fix --config=.php_cs -v --dry-run --using-cache=no --show-progress=dots --diff $(git diff -- '*.php' --name-only --diff-filter=ACMRTUXB "${TRAVIS_COMMIT_RANGE}")

UPGRADE-3.0.md

@@ -103,6 +103,7 @@ All fixtures must be defined as services in a bundle's config.php
 *   Removed deprecated \Mautic\CoreBundle\Templating\Helper\ButtonHelper::renderPreCustomButtons use renderButtons() instead
 *   Removed deprecated \Mautic\CoreBundle\Templating\Helper\ButtonHelper::renderPostCustomButtons
 *   Removed deprecated \Mautic\CoreBundle\Templating\Helper\ButtonHelper::setCustomButtons; listen to  CoreEvents::VIEW_INJECT_CUSTOM_BUTTONS event instead
+*   Removed command class GenerateMigrationsCommand as it was broken with new Doctrine. Instead of `mautic:migrations:generate` use command `doctrine:migrations:generate` to generate a migration class.
 *   Abstract class CommonStatsSubscriber was refactored out of CommonSubscriber and so it needs its own dependencies: CorePermissions and EntityManager. All classes extending CommonStatsSubscriber must provide those dependencies.
 *   Protected methods CommonStatsSubscriber::addContactRestrictedRepositories() and CommonStatsSubscriber::addContactRestrictedRepositories() do not have the first parameter of EntityManager. See the point above. The second parameter must be an array now.
 *   CommonSubscriber removed. Implement Symfony\Component\EventDispatcher\EventSubscriberInterface directly and use DI instead.

app/config/config.php

@@ -300,10 +300,11 @@ function ($v) {
 
 //MigrationsBundle Configuration
 $container->loadFromExtension('doctrine_migrations', [
-    'dir_name'   => '%kernel.root_dir%/migrations',
-    'namespace'  => 'Mautic\\Migrations',
-    'table_name' => '%env(MAUTIC_MIGRATIONS_TABLE_NAME)%',
-    'name'       => 'Mautic Migrations',
+    'dir_name'        => '%kernel.root_dir%/migrations',
+    'namespace'       => 'Mautic\\Migrations',
+    'table_name'      => '%env(MAUTIC_MIGRATIONS_TABLE_NAME)%',
+    'name'            => 'Mautic Migrations',
+    'custom_template' => '%kernel.root_dir%/migrations/Migration.template',
 ]);
 
 // Swiftmailer Configuration

app/migrations/Migration.template

@@ -0,0 +1,36 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * @copyright   <year> Mautic Contributors. All rights reserved.
+ * @author      Mautic
+ * @link        https://mautic.org
+ * @license     GNU/GPLv3 http://www.gnu.org/licenses/gpl-3.0.html
+ */
+
+namespace Mautic\Migrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\Exception\SkipMigration;
+use Mautic\CoreBundle\Doctrine\AbstractMauticMigration;
+
+final class Version<version> extends AbstractMauticMigration
+{
+    /**
+     * @throws SkipMigrationException
+     */
+    public function preUp(Schema $schema)
+    {
+        $shouldRunMigration = false; // Please modify to your needs
+
+        if (!$shouldRunMigration) {
+            throw new SkipMigration('Schema includes this migration');
+        }
+    }
+
+    public function up(Schema $schema)
+    {
+        // Please modify to your needs
+    }
+}

phpstan.neon

@@ -25,5 +25,4 @@ parameters:
 		- '#Constant MAUTIC_TABLE_PREFIX not found.#'
 		- '#Constant MAUTIC_ENV not found.#'
 		- '#Constant MAUTIC_VERSION not found.#'
-		- '#Constant MAUTIC_ROOT_DIR not found.#'
 		- '/Variable \$\w+ might not be defined\./'