Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tooltip of scheduled emails #8733

Merged

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Apr 26, 2020

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Just small improvement to tooltip scheduled emails. Added date start sending at and stop sending at

image

image

Steps to test this PR:

  1. Load up this PR
  2. Create email with Publish at (date/time) in future and go to email lists and check tooltip
  3. Create email with Unpublish at (date/time) in past and go to email list and related check tooltip

List deprecations along with the new alternative:

List backwards compatibility breaks:

@kuzmany kuzmany added ready-to-test PR's that are ready to test enhancement Any improvement to an existing feature or functionality labels Apr 26, 2020
@kuzmany kuzmany added this to the 3.0.1 milestone Apr 26, 2020
@kuzmany kuzmany changed the base branch from staging to 3.x April 26, 2020 15:48
@kuzmany kuzmany force-pushed the scheduled-emails-improve-tooltips branch from 28f3cc9 to 362d12d Compare April 26, 2020 15:50
@kuzmany kuzmany changed the title Improve tooltips scheduled emails Improve tooltip of scheduled emails Apr 26, 2020
@TravisBuddy
Copy link

Hey @kuzmany,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 279d08f0-87d8-11ea-9c26-c9c9fa839a9b

Copy link

@StrategieSociali StrategieSociali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is just my first test and I hope everything I have done is correct. With "Published on the future" all seem ok, I can see the clock and the correct description. The past doesn't work. Whether I program in the past with published or unpublished, whether I program in the future and wait for the programming time to pass, I get the same result: the email goes in "not published"

@RCheesley RCheesley changed the base branch from 3.x to staging June 17, 2020 11:46
@RCheesley RCheesley modified the milestones: 3.0.1, 3.1.0 Jun 17, 2020
RCheesley
RCheesley previously approved these changes Aug 15, 2020
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice PR @kuzmany - a small but helpful improvement to the UX.

Confirm that the tooltip is applied with the PR as I would expect:

Emails _ Mautic

@RCheesley RCheesley added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Aug 15, 2020
@RCheesley
Copy link
Sponsor Member

@StrategieSociali thanks for testing! To get these conditions you need to create two emails. In one of them set the publish at date/time in the future. This will be in the 'pending' status.

screenshot-local mautic3-2020 08 15-21_48_33

In the second email (I just cloned the one above in my case!) remove the publish at date, and set the unpublish at date/time to something in the past. This will be in the 'expired' status.

screenshot-local mautic3-2020 08 15-21_50_09

Hope that makes sense - the test instructions could have been clearer!

Copy link
Member

@dennisameling dennisameling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dennisameling dennisameling added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Aug 15, 2020
@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #8733 into staging will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging    #8733   +/-   ##
==========================================
  Coverage      29.88%   29.88%           
  Complexity     33258    33258           
==========================================
  Files           1937     1937           
  Lines         115196   115196           
==========================================
  Hits           34428    34428           
  Misses         80768    80768           

@dennisameling dennisameling merged commit 06228d8 into mautic:staging Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants