-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tooltip of scheduled emails #8733
Improve tooltip of scheduled emails #8733
Conversation
28f3cc9
to
362d12d
Compare
Hey @kuzmany, TravisCI finished with status TravisBuddy Request Identifier: 279d08f0-87d8-11ea-9c26-c9c9fa839a9b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is just my first test and I hope everything I have done is correct. With "Published on the future" all seem ok, I can see the clock and the correct description. The past doesn't work. Whether I program in the past with published or unpublished, whether I program in the future and wait for the programming time to pass, I get the same result: the email goes in "not published"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice PR @kuzmany - a small but helpful improvement to the UX.
Confirm that the tooltip is applied with the PR as I would expect:
@StrategieSociali thanks for testing! To get these conditions you need to create two emails. In one of them set the publish at date/time in the future. This will be in the 'pending' status. In the second email (I just cloned the one above in my case!) remove the publish at date, and set the unpublish at date/time to something in the past. This will be in the 'expired' status. Hope that makes sense - the test instructions could have been clearer! |
362d12d
to
fcb84be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Codecov Report
@@ Coverage Diff @@
## staging #8733 +/- ##
==========================================
Coverage 29.88% 29.88%
Complexity 33258 33258
==========================================
Files 1937 1937
Lines 115196 115196
==========================================
Hits 34428 34428
Misses 80768 80768 |
Please be sure you are submitting this against the staging branch.
Description:
Just small improvement to tooltip scheduled emails. Added date start sending at and stop sending at
Steps to test this PR:
List deprecations along with the new alternative:
List backwards compatibility breaks: