Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix A/B test winner 500 error #8856

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented May 31, 2020

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8853
BC breaks?
Deprecations?

Description:

I created an email which had an AB variant and ran the test. When I clicked to determine which one would become the winner a 500 error was thrown.

Steps to reproduce

  1. Create email with a/b test variant
  2. Run the test
  3. Click on the trophy to decide the winner and accept the warning
  4. Notice the 500 error

Log errors

[2020-05-30 14:02:14] mautic.CRITICAL: Uncaught PHP Exception InvalidArgumentException: "The _controller value "MauticEmailBundle:Page:view" maps to a "Mautic\EmailBundle\Controller\PageController" class, but this class was not found. Create this class or check the spelling of the class and its namespace." at /Users/ruth.cheesley/Sites/local.mautic3/vendor/symfony/framework-bundle/Controller/ControllerNameParser.php line 90 {"exception":"[object] (InvalidArgumentException(code: 0): The _controller value "MauticEmailBundle:Page:view" maps to a "Mautic\EmailBundle\Controller\PageController" class, but this class was not found. Create this class or check the spelling of the class and its namespace. at /Users/ruth.cheesley/Sites/local.mautic3/vendor/symfony/framework-bundle/Controller/ControllerNameParser.php:90)"} []

Steps to test this PR:

  1. Load up this PR

List deprecations along with the new alternative:

List backwards compatibility breaks:

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test regression A bug that broke something in the last release labels May 31, 2020
@kuzmany kuzmany added this to the 3.0.0 milestone May 31, 2020
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and bug is resolved, thanks @kuzmany !

@RCheesley RCheesley added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels May 31, 2020
@RCheesley RCheesley linked an issue May 31, 2020 that may be closed by this pull request
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 😎

@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Jun 11, 2020
@dennisameling dennisameling merged commit d29a619 into mautic:3.x Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged regression A bug that broke something in the last release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting A/B test winner on email results in a 500 error
4 participants