Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mysqli issue with Mautic 3 DB migrations #8961

Merged
merged 1 commit into from
Jun 28, 2020
Merged

Fix mysqli issue with Mautic 3 DB migrations #8961

merged 1 commit into from
Jun 28, 2020

Conversation

dennisameling
Copy link
Member

@dennisameling dennisameling commented Jun 27, 2020 •
edited
Loading

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? x
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) Closes #8946
BC breaks?
Deprecations?

Description:

This PR fixes Mautic 3 DB migration errors with the mysqli driver, which was reported in #8946.

Steps to reproduce the bug:

  1. Follow the steps mentioned in Mautic 3 database migrations failing with mysqli as database driver #8946 (option 1 is the easiest & fastest to test)

Steps to test this PR:

  1. Clone this PR locally, e.g. with the GitHub CLI gh pr checkout 8961
  2. Repeat the steps in Mautic 3 database migrations failing with mysqli as database driver #8946, the rollback should now succeed without errors
  3. Run bin/console doctrine:migrations:migrate --no-interaction to make sure your installation is up-to-date with DB migrations again.

@dennisameling dennisameling added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test essential This must be done to close the milestone labels Jun 27, 2020
@dennisameling dennisameling added this to the 3.0.1 milestone Jun 27, 2020
@dennisameling dennisameling changed the title Fix mysqli issue Fix mysqli issue with Mautic 3 DB migrations Jun 27, 2020
@codecov
Copy link

codecov bot commented Jun 27, 2020

Codecov Report

Merging #8961 into staging will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging    #8961   +/-   ##
==========================================
  Coverage      35.25%   35.25%           
  Complexity     27889    27889           
==========================================
  Files           1731     1731           
  Lines          96725    96725           
==========================================
  Hits           34099    34099           
  Misses         62626    62626

RCheesley
RCheesley approved these changes Jun 27, 2020
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the bug with the migration and the fix.

Is there a possibility to patch this back to Mautic 2.x as I am concerned that this bug will prevent some folk updating and hence migrating to Mautic 3.x.

@dennisameling
Copy link
Member Author

@RCheesley No need to backport to 2.x as the affected migration doesn't exist in 2.x, only in 3. 😊

@RCheesley
Copy link
Sponsor Member

RCheesley commented Jun 27, 2020 •
edited
Loading

@RCheesley No need to backport to 2.x as the affected migration doesn't exist in 2.x, only in 3. 😊

Ah OK - misunderstood the migration being from 2019 😊

@RCheesley RCheesley added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Jun 27, 2020
escopecz
escopecz approved these changes Jun 28, 2020
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Jun 28, 2020
@dennisameling dennisameling merged commit cca50ad into mautic:staging Jun 28, 2020
@dennisameling dennisameling deleted the fix-mysqli-issue branch June 28, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@RCheesley RCheesley RCheesley approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs essential This must be done to close the milestone ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

Mautic 3 database migrations failing with mysqli as database driver
3 participants
@dennisameling @RCheesley @escopecz