Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix absolute url of preview email #9329

Merged
merged 3 commits into from
Mar 13, 2021
Merged

Fix absolute url of preview email #9329

merged 3 commits into from
Mar 13, 2021

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Oct 25, 2020 •
edited by npracht
Loading

Q A
Branch? 3.3
Bug fix? yes
New feature? no
Deprecations? no
BC breaks? no
Automated tests included? no
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed

Description:

Email preview link was not absolute url. This PR fixed it

Steps to test this PR:

  1. Load up this PR
  2. Create email
  3. See preview link is in format /email/preview/xxx, expect https://mauticurl/email/preview/xxx
  4. This PR fixed it

image

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 25, 2020
@kuzmany kuzmany added this to the 3.2 milestone Oct 25, 2020
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Oct 25, 2020
@TravisBuddy
Copy link

Hey @kuzmany,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: b3dec510-16a8-11eb-a761-09290313622d

@dennisameling
Copy link
Member

Closing and re-opening now that Travis composer is fixed #9332

@dennisameling dennisameling reopened this Oct 26, 2020
@codecov
Copy link

codecov bot commented Oct 26, 2020 •
edited
Loading

Codecov Report

Merging #9329 (fb488fe) into 3.3 (00f4274) will not change coverage.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.3    #9329   +/-   ##
=========================================
  Coverage     38.73%   38.73%           
  Complexity    34021    34021           
=========================================
  Files          1988     1988           
  Lines        105170   105170           
=========================================
  Hits          40741    40741           
  Misses        64429    64429
Impacted Files Coverage Δ Complexity Δ
...bundles/EmailBundle/Controller/EmailController.php 22.09% <60.00%> (ø) 145.00 <0.00> (ø)

@RCheesley RCheesley added the hacktoberfest Issues that would be great for Hacktoberfest participants to work on label Oct 26, 2020
@escopecz escopecz added the needs-automated-tests PR's that need automated tests before they can be merged label Oct 28, 2020
@npracht npracht modified the milestones: 3.2.0, 3.2.1 Nov 23, 2020
@dennisameling dennisameling modified the milestones: 3.2.1, 3.2.2 Dec 2, 2020
@npracht npracht modified the milestones: 3.2.2, 3.2.3 Dec 21, 2020
@npracht npracht modified the milestones: 3.2.3, 3.2.5, 3.3.1 Jan 15, 2021
@npracht npracht changed the base branch from staging to features January 19, 2021 16:18
@RCheesley RCheesley modified the milestones: 3.3.1, 3.3.2 Feb 23, 2021
@npracht npracht added the email Anything related to email label Mar 2, 2021
@npracht npracht changed the base branch from features to 3.3 March 2, 2021 14:10
@npracht npracht removed the needs-automated-tests PR's that need automated tests before they can be merged label Mar 2, 2021
npracht
npracht approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

npracht
npracht approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@npracht npracht added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test hacktoberfest Issues that would be great for Hacktoberfest participants to work on labels Mar 2, 2021
@RCheesley RCheesley added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Mar 12, 2021
@mohit-rocks mohit-rocks merged commit 5ba3038 into mautic:3.3 Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement email Anything related to email ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.
7 participants
@kuzmany @TravisBuddy @dennisameling @npracht @escopecz @mohit-rocks @RCheesley