Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Events aren't parsed, leading to slightly confusing debug message #32

Closed
dbkr opened this issue May 7, 2021 · 2 comments
Closed

Comments

@dbkr
Copy link

dbkr commented May 7, 2021

Whenever call events arrive, we get a log message like this:

DEBUG [2021-05-06T22:22:26.606378555Z] Failed to parse content of [$tFsRCPRjzbsPMfBBDPwtygFdo0PPa2rd67yKWZJdFYU m.call.hangup unsupported content type m.call.hangup (message)] (%!s(MISSING)): %!v(MISSING)

It looks like this is just because the Call events types aren't recognised as Message events in GuessClass - looks like the structures are all there so I guess the types just need to be added here?

Also I'm not sure where the %s(MISSING) stuff is coming from in the log line. For unknown event types, maybe something like, "Unknown message type /: not parsing" would be a better debug log?

@tulir
Copy link
Member

tulir commented May 7, 2021

GuessClass shouldn't be needed for parsing incoming events. The call structs were added recently (in v0.9.7), are you using a new enough version?

tulir added a commit that referenced this issue May 7, 2021
@dbkr
Copy link
Author

dbkr commented May 7, 2021

Aha - I was not, sorry! That now gets further and have opened #33

@dbkr dbkr closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants