-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic create command #250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OK, now it works
|
invite puppets properly
Setting avatar now works. I suppose the create command is complete. |
sumnerevans
previously requested changes
Apr 26, 2022
Co-authored-by: Sumner Evans <me@sumnerevans.com>
Co-authored-by: Sumner Evans <me@sumnerevans.com>
Co-authored-by: Sumner Evans <me@sumnerevans.com>
tulir
reviewed
May 4, 2022
tulir
reviewed
May 4, 2022
tulir
reviewed
May 10, 2022
Co-authored-by: Tulir Asokan <tulir@maunium.net>
tulir
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still a few problems. I'm not sure if they are caused by or just triggered by my changes
create
, I will get a message that I already have a private chat with the user and the ghost leaves the room. I'm not sure how this is handled on the telegram bridge. IMHO, automatic dm creation should be limited to matrix rooms marked as direct. Inviting ghosts to rooms marked as rooms may trigger group creation in the future.create
, that ghost leaves the room.member_role is currently set to DEFAULT. I suppose there isn't really a need to expose ADMINISTRATOR as an option. It's possibly somewhat related to a trusted private chat, but according to my understanding, the latter makes everyone who may join that room in the future automatically admin and the former only does that for the initial members. It's probably best to just map the power levels from the matrix side to signal
edit:
2 has changed with the fix for the invite implementation. The ghost still joins immediately but is no longer kicked. It also isn't added to the group upon group creation.