Add ProofRequiredError Exception and submit-challenge command #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltee1
force-pushed
the
captcha_challenge
branch
from
e4f49ad
to
4785d74
Compare
maltee1
force-pushed
the
captcha_challenge
branch
2 times, most recently
from
3d7768b
to
86fd9b9
Compare
maltee1
force-pushed
the
captcha_challenge
branch
from
86fd9b9
to
fa19ed5
Compare
|
Tested & working. Please have a look. |
tulir
approved these changes
Apr 30, 2023
|
How do I get the captcha token? Thanks |
|
I can't, because the python version of the bridge is deprecated. I suppose the go version will at some point have a similar command, if captchas continue to be requested. Here's the documentation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still entirely untested since I would need a ProofRequiredError to do so. I am not currently commited enough to try and trigger one for my Signal account, but anyone who has one, please try. Or if you find obvious mistakes without testing, let me know.
I've noticed that ProofRequiredError rarely comes in the SendMessageResult, but usually as a ResponseError, so I created another ProofRequiredException in errors.py. I didn't know how to reconcile the two, since SendMessageResult probably wouldn't work with an Exception instead of a SerializableAttrs, but I also needed to inherit from ResponseError.
When portal.handle_matrix_message() encounters a ProofRequiredError, it should store a token in the respective user, so the user won't have to copy&paste that. Since tokens are temporary in nature and I don't know how to work with databases, it's not stored in the database. I suppose that's fine.
The user can then use the submit-challenge command with just a captcha token to complete the challenge. I currently don't handle PUSH_CHALLENGE. So far, I have only encountered RECAPTCHA, I would prefer to first handle that and then worry about the other (probably just two lines, but still).