ARM support #89
Merged
ARM support #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NAR plugin for Maven » nar-maven-plugin #122 SUCCESS |
|
Looks good to me except the obvious omission in the commit message that states from where this section was copied (and maybe adjusted?)... Could you add that comment (via |
dscho
added a commit
that referenced
this pull request
Mar 25, 2014
This branch adds initial ARM support. Note that this is basically a copy-edit of the '# Linux' section, i.e. Linux i386. This merge accepts the pull request #89. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Thanks! I added the information I would have loved to see in the commit message in the merge commit message instead. It is slightly harder to find, but better than nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial ARM support. Please note that I'm not sure if the compiler/linker flags are OK - double check this. We use this patch in Fedora and it works well.