Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if body is null #26

Merged
merged 1 commit into from Jan 8, 2020
Merged

Check if body is null #26

merged 1 commit into from Jan 8, 2020

Conversation

tidharmor
Copy link

using client.ServerInformation.TriggerServerInstanceBackup calls Post with null body which causes an exception.

using client.ServerInformation.TriggerServerInstanceBackup calls Post with null body which causes an exception.
@oubenal
Copy link

oubenal commented Nov 24, 2019

instead u could replace null with an empty string in line below (called by TriggerServerInstanceBackup )

var response = httpClient.Post(url, null, HttpContentTypes.TextPlain);

@tidharmor
Copy link
Author

instead u could replace null with an empty string in line below (called by TriggerServerInstanceBackup )

var response = httpClient.Post(url, null, HttpContentTypes.TextPlain);

But then you risk having another call to Post with null.
If you fix the Post/Put extension methods you eliminate this bug in other places if it exists.

@mavezeau mavezeau merged commit 6484452 into mavezeau:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants