Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: cli: Fix enable-webrtc-task-test always enabled #321

Conversation

joaoantoniocardoso
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso commented Dec 1, 2023

The original logic fails to account for when the parameter was not passed because it has a default value.

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@patrickelectric patrickelectric merged commit a734bcb into mavlink:master Dec 1, 2023
3 checks passed
@joaoantoniocardoso joaoantoniocardoso deleted the fix_cli_enable_webrtc_task_test_always_enabled branch December 1, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants