Better signalling server #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move from tokio_tungstenite to async_tungstenite - Better WebSocket protocol handling - Better task handling
patrickelectric
approved these changes
Feb 5, 2024
| .expect("Error starting Signalling server"); | ||
| debug!("Starting SignallingServer task..."); | ||
|
|
||
| let handle = Some(tokio::spawn(async move { |
There was a problem hiding this comment.
is it possible for the handle to be None ?
There was a problem hiding this comment.
It's not. I'm using Option because of the Drop part of the code, which requires the handle to be moved inside the spawned task.
|
Will this require changes on the client side (e.g.: Cockpit)? |
No, nothing has changed for the clients :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.