Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter protocol updates for encoding method #436

Merged
merged 3 commits into from
Mar 3, 2022

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Feb 16, 2022

Essentially we have two parameter protocols, that pretty much differ only in that PX4 uses byte-wise encoding and ArduPilot uses C-style encoding (there are other differences, but most of these are not incompatible - more like extensions).

The suggestion by @auturgy here: mavlink/mavlink#1769 (comment) was that we simply use the protocol bits MAV_PROTOCOL_CAPABILITY_PARAM_UNION and MAV_PROTOCOL_CAPABILITY_PARAM_FLOAT to differentiate these. These can then also be used for discovery of the protocol.

I like this because it more accurately reflects the actual history - early inconsistency in the implementations, and further, it might actually have been the intent of these protocol bits originally.

Do not merge until mavlink/mavlink#1799 is finalised. If merges, will need to update the protocol bits documented.

  • MAV_PROTOCOL_CAPABILITY_PARAM_ENCODE_BYTEWISE
  • MAV_PROTOCOL_CAPABILITY_PARAM_ENCODE_C_CAST

@hamishwillee hamishwillee marked this pull request as draft February 17, 2022 00:20
@hamishwillee hamishwillee marked this pull request as ready for review March 2, 2022 23:56
@hamishwillee
Copy link
Collaborator Author

mavlink/mavlink#1799 has merged - this is the corresponding docs update.

@hamishwillee hamishwillee changed the title DISCUSS Parameter protocol updates for encoding method Parameter protocol updates for encoding method Mar 2, 2022
@hamishwillee hamishwillee merged commit 4238177 into master Mar 3, 2022
@hamishwillee hamishwillee deleted the parameter_updates branch March 3, 2022 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant