Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Control add 4 more joystick axes (channels 5-8) #1147

Conversation

m1kelyons
Copy link

Proposal to extend the manual_control MAVLink message for extra channels. See RFC 0015 - Mavlink MANUAL_CONTROL message extension PR

@hamishwillee hamishwillee added the Dev Call Issues to be discussed during the Dev Call label May 29, 2019
@hamishwillee
Copy link
Collaborator

@m1kelyons

Thanks for attending the meeting last night. Here is summary of concerns:

  • This turns the MANUAL_CONTROL message which has unambiguous purpose independent of flight stack into one that requires separate parameter support/interpretation for flight stacks - ie it is more like RC_OVERRIDE
  • Also there are other messages that do the things this is intended for, so we can use those, and if needed add missing cases.
  • We would consider an extension where the purpose of each channel is defined in an enum (ie so there is no flight-stack specific params etc), but leaning towards extra messages to reduce the cost for cases where this is not needed.

The discussion faded out a bit for me at this point, but I believe that the action was to close this and for you to take some more time to think about it. Is that your understanding Mike?

@LorenzMeier
Copy link
Member

@m1kelyons Any further input here? The more defined we can make it, the more sense it makes to pull it in.

@hamishwillee
Copy link
Collaborator

@m1kelyons ^^^ ?

@hamishwillee
Copy link
Collaborator

@LorenzMeier I propose we close this unless @m1kelyons has further comment?

@hamishwillee
Copy link
Collaborator

Closing. Inactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Call Issues to be discussed during the Dev Call
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants