OPTICAL_FLOW.flow_comp_m_(x/y) units to m/s #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
approved these changes
Aug 5, 2019
|
Discussed in dev call. Agreed that code for implementation of this message is velocity. Can be merged. |
jlecoeur
approved these changes
Aug 8, 2019
julianoes
approved these changes
Aug 8, 2019
amilcarlucas
pushed a commit
to amilcarlucas/mavlink
that referenced
this pull request
Sep 24, 2019
As stated by @jlecoeur the OPTICAL_FLOW.flow_comp_m_x and flow_comp_m_y must either be velocity units or an integration time unit is required so that flow can be determined from these. Given there is no such integration unit it is very likely that people are assuming m/s OR that it is not being used. Either way, the "best" fix is to clarify m/s.
tridge
pushed a commit
to ArduPilot/mavlink
that referenced
this pull request
Oct 8, 2019
As stated by @jlecoeur the OPTICAL_FLOW.flow_comp_m_x and flow_comp_m_y must either be velocity units or an integration time unit is required so that flow can be determined from these. Given there is no such integration unit it is very likely that people are assuming m/s OR that it is not being used. Either way, the "best" fix is to clarify m/s.
CraftyJax
pushed a commit
to planckaero/mavlink
that referenced
this pull request
Nov 19, 2020
As stated by @jlecoeur the OPTICAL_FLOW.flow_comp_m_x and flow_comp_m_y must either be velocity units or an integration time unit is required so that flow can be determined from these. Given there is no such integration unit it is very likely that people are assuming m/s OR that it is not being used. Either way, the "best" fix is to clarify m/s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1187
As stated by @jlecoeur the
OPTICAL_FLOW.flow_comp_m_xandflow_comp_m_ymust either be velocity units or an integration time unit is required so that flow can be determined from these. Given there is no such integration unit it is very likely that people are assuming m/s OR that it is not being used. Either way, the "best" fix is to clarify m/s.Still waiting for confirmation on linked item from @auturgy.