-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Support for optional values in MISSION_ITEM_INT.[x|y] #1286
Comments
How about INT32_MAX? |
Yup |
@auturgy Any thoughts on this one? |
@DonLakeFlyer Do either of these work better for you ... ? A modification of the params:
Or in the description
|
Look at MAV_CMD_DO_ORBIT. That has NaN support in param 5/6/7 |
Thanks. See #1303 for proposed wording. You need to review :-) |
As the spec currently stands the x and y values of MISSION_ITEM_INT have no mechanism to indicate an optional value. With MISSION_ITEM this is commonly done by setting the value to a NaN. Without this it limits the parameter usage for mission items which are not location based and use x/y for other things than a lat/lon. Even given that I would contend that the ability to support am optional value in lat/lon can be useful as well. For example a TAKEOFF item that has optional location with it.
We can accomplish this by spec'ing a max int value in x/y indicates the lack of an optional value.
The reason to spec that at the MISSION_ITEM_INT level as opposed to each individual message is to give a gcs enough information to handle this internally. At least for QGC it stores mission items with doubles internally and converts them as they come on. In order to do that correctly it needs to know that for any MISSION_ITEM_INT a max int value in x/y means optional. And it should convert it to a NaN on the way in.
The text was updated successfully, but these errors were encountered: