Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16-cell support #1747

Closed
wants to merge 1 commit into from
Closed

Conversation

muramura
Copy link
Contributor

Devices that support up to 16 cells have been shipped.
QGC can be selected up to 16 cells.

@hamishwillee
Copy link
Collaborator

We can't do this as it is an incompatible change to the message. I'll add a discussion in the dev call today.

@amilcarlucas
Copy link
Collaborator

I just added support for 14 cells to mavros, and there is a mavros PR to support upto 10 batteries.
Breaking the message is not a good idea, but better now than later.

@hamishwillee
Copy link
Collaborator

@amilcarlucas The PR that was proposed here was a compatibility break, so we will never use this approach.

In theory we might add another extension field to the end of the message with yet more cells. The problem with that approach is that this message is sent a LOT - but in most cases the cells aren't used and can't be truncated. Causing problems for real-world users.

Last time we discussed this we agreed that we wouldn't just extend the message without looking at alternatives. I'll put a placeholder in the devcall to discuss - happy to take a proposal that is more extensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants