Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPONENT_INFORMATION: dynamic updates #1790

Closed
wants to merge 1 commit into from

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Feb 2, 2022

A new use-case for component information peripherals has come up: keeping track of attached smart batteries (name, serial number, etc.). This means we need to handle dynamic updates.
For that a new message is added that is broadcast at regular intervals (after an update), containing the minimal state (the CRC's) with which clients can detect updates and re-request the metadata.

@bkueng bkueng force-pushed the component_information_dynamic_updates branch from a4b8e57 to fdfc703 Compare February 2, 2022 07:33
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense.

@hamishwillee
Copy link
Collaborator

@auturgy Thoughts on this addition?

My first reaction was use an enum and broadcast for just the affected file. Was discussed in the dev call and this is not needed or desirable.

@hamishwillee
Copy link
Collaborator

As discussed in Dev call 20220216

  • this seems a reasonable proposal for making component information dynamic.
  • this might not be the best way of supplying this information though. The use case is smart batteries, so we could include the info in SMART_BATTERY_INFO.
  • I am going to make this into Draft. @bkueng please either move back into active or close when you have made a decision on best approach.

@bkueng Just a thought, but is there any way that asset tracking like this could instead be done with COMPONENT_INFORMATION_BASIC? I guess you lose the association with the specific battery being attached but it feels like a more general approach.

@hamishwillee hamishwillee marked this pull request as draft February 16, 2022 23:30
@bkueng
Copy link
Member Author

bkueng commented Feb 17, 2022

@bkueng Just a thought, but is there any way that asset tracking like this could instead be done with COMPONENT_INFORMATION_BASIC? I guess you lose the association with the specific battery being attached but it feels like a more general approach.

The challenge with that is that a single mavlink component needs to emit multiple sub-components and handle disconnects.

@hamishwillee
Copy link
Collaborator

Propose you close this, or use it for all the updates. As discussed in #1806 (comment) we're using a slightly different approach for dynamic updates.

@bkueng bkueng closed this Mar 17, 2022
@bkueng bkueng deleted the component_information_dynamic_updates branch March 17, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants